Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Added custom markdown css#1996

Merged
sosukesuzuki merged 4 commits into
BoostIO:masterfrom
ZeroX-DG:custom-markdown-css
Jun 4, 2018
Merged

Added custom markdown css#1996
sosukesuzuki merged 4 commits into
BoostIO:masterfrom
ZeroX-DG:custom-markdown-css

Conversation

@ZeroX-DG

Copy link
Copy Markdown
Member

With this feature, users can now customize how the markdown should look like. More info: https://issuehunt.io/repos/53266139/issues/184

Here is how it looks
peek 2018-05-29 11-44

As you can see, the user can choose to use custom css or not by clicking on the allow custom css checkbox in the preview section and then specify the custom css in the code editor bellow.

By default the custom css is disabled.

If the user export the note as html, their custom style will be applied too.

@IssueHuntBot IssueHuntBot mentioned this pull request May 29, 2018
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label May 29, 2018
@sosukesuzuki sosukesuzuki self-requested a review June 1, 2018 05:34

@sosukesuzuki sosukesuzuki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZeroX-DG
Please confirm my review!

{i18n.__('Custom CSS')}
</div>
<div styleName='group-section-control'>
<ReactCodeMirror onChange={e => this.handleUIChange(e)} ref={e => (this.customCSSCM = e)} value={config.preview.customCSS} options={{ lineNumbers: true, mode: 'css', theme: codemirrorTheme }} />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ReactCodeMirror is too huge...
Set the width of this according to the editor.
2018-06-01 14 32 15

@ZeroX-DG

ZeroX-DG commented Jun 3, 2018

Copy link
Copy Markdown
Member Author

@sosukesuzuki I have changed my code, please have a look 😃

@sosukesuzuki sosukesuzuki merged commit d634e11 into BoostIO:master Jun 4, 2018
@sosukesuzuki sosukesuzuki added next release (v0.11.5) and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 4, 2018
@ZeroX-DG ZeroX-DG deleted the custom-markdown-css branch June 5, 2018 14:35
@J-F-Liu

J-F-Liu commented Oct 24, 2018

Copy link
Copy Markdown

Suggest define Custom CSS as multiple theme, and user can associate different notes with different CSS themes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants