This repository was archived by the owner on May 12, 2026. It is now read-only.
Fix file list blinking on search#2065
Merged
sosukesuzuki merged 2 commits intoJun 12, 2018
Merged
Conversation
Contributor
|
@Flaps please fix from eslint! |
Contributor
|
I fixed from eslint!:+1: |
sosukesuzuki
approved these changes
Jun 12, 2018
sosukesuzuki
left a comment
sosukesuzuki
left a comment
Contributor
There was a problem hiding this comment.
Thank you for your great contribution!:smile:
LGTM:+1:
sosukesuzuki
added
next release (v0.11.6)
and removed
awaiting review ❇️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2063
Issue solved, with trick after the search input.
Here I avoid selected file blinking in the notes list.
Trying to estimate whic file would be selected after the search, before router triggers the file name.