Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

Replace current fullscreen button of SnippetNote to FullscreenButton module#2770

Merged
Rokt33r merged 1 commit into
BoostIO:masterfrom
vienai8d:update_snippet_note
Jan 7, 2019
Merged

Replace current fullscreen button of SnippetNote to FullscreenButton module#2770
Rokt33r merged 1 commit into
BoostIO:masterfrom
vienai8d:update_snippet_note

Conversation

@vienai8d

@vienai8d vienai8d commented Jan 1, 2019

Copy link
Copy Markdown
Contributor

Description

For #2769.

Replace current fullscreen button of SnippetNote to FullscreenButton in reference to MarkdownNoteDetail.

Before
2019-01-01 22 08 01

After
2019-01-01 23 15 42

Issue fixed

#2769

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible
@vienai8d vienai8d changed the title use FullscreenButton instead of current button Jan 2, 2019
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 2, 2019
ZeroX-DG
ZeroX-DG approved these changes Jan 3, 2019
View reviewed changes

@ZeroX-DG ZeroX-DG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jan 3, 2019
@Rokt33r Rokt33r added next release (v0.11.13) and removed approved 👍 Pull request has been approved by sufficient reviewers. labels Jan 7, 2019
@Rokt33r Rokt33r merged commit 5a5563f into BoostIO:master Jan 7, 2019
@vienai8d vienai8d deleted the update_snippet_note branch January 7, 2019 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@vienai8d @ZeroX-DG @Rokt33r