Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

fix image path due to bad regex#2848

Merged
Rokt33r merged 6 commits into
BoostIO:masterfrom
daiyam:fix-gallery
Jan 31, 2019
Merged

fix image path due to bad regex#2848
Rokt33r merged 6 commits into
BoostIO:masterfrom
daiyam:fix-gallery

Conversation

@daiyam

@daiyam daiyam commented Jan 29, 2019

Copy link
Copy Markdown
Contributor

Description

This change is base on the work of @ehhc (PR #2835).
The difference is that it won't break the gallery feature and improve a test to correctly assert all image paths are correctly generated.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible
ehhc and others added 5 commits January 26, 2019 17:21
…d that issue in the future + test modified so that they both contain tests for posix and windows path separator -> fixes BoostIO#2834
- improve test
- fix missing 'e' in some functions name
@guardrails

guardrails Bot commented Jan 29, 2019

Copy link
Copy Markdown

No more findings on this branch.
This means you fixed everything we detected earlier. Good job!! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

Happy with the results? Give your feedback.

@Rokt33r

Rokt33r commented Jan 30, 2019

Copy link
Copy Markdown
Member

Awesome! I'll test this today!! 😄

@Rokt33r Rokt33r merged commit f1b929c into BoostIO:master Jan 31, 2019
@daiyam daiyam deleted the fix-gallery branch January 31, 2019 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants