Skip to content

feat: add experimental --exclude-allocations setting#425

Open
not-matthias wants to merge 1 commit into
mainfrom
cod-3016-add-runneraction-setting-to-exclude-memory-allocators
Open

feat: add experimental --exclude-allocations setting#425
not-matthias wants to merge 1 commit into
mainfrom
cod-3016-add-runneraction-setting-to-exclude-memory-allocators

Conversation

@not-matthias

Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing cod-3016-add-runneraction-setting-to-exclude-memory-allocators (9f62198) with main (7ce2c98)

Open in CodSpeed
@not-matthias not-matthias marked this pull request as ready for review June 26, 2026 17:14
@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds an experimental option to exclude allocation time from uploaded run metadata. The main changes are:

  • New --exclude-allocations CLI flag and environment variable.
  • Propagation through run and exec configuration.
  • Upload metadata includes the setting only when enabled.
  • Default metadata serialization remains unchanged when the option is off.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
src/cli/experimental.rs Adds the experimental flag and reports it as active only when enabled.
src/executor/config.rs Adds the allocation-exclusion setting to orchestrator and executor configuration.
src/run_environment/provider.rs Passes the allocation-exclusion setting into upload metadata.
src/upload/interfaces.rs Serializes the allocation-exclusion metadata only when the setting is enabled.

Reviews (2): Last reviewed commit: "feat: add experimental --exclude-allocat..." | Re-trigger Greptile

Comment thread src/upload/interfaces.rs
Add an experimental `--exclude-allocations` flag (env
`CODSPEED_EXCLUDE_ALLOCATIONS`) that signals the backend to exclude
memory allocation time from simulation results.

The value is surfaced as `runner.excludeAllocations` in the upload
metadata so the backend can gate comparability and history on it: runs
with different values are not comparable. The field is additive, so the
metadata version stays at 10 and older payloads remain compatible.

COD-3016
@not-matthias not-matthias force-pushed the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch from 16220f0 to 9f62198 Compare June 26, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant