refactor: rename Mahiro CFG to Similarity-Adaptive Guidance #12172
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the display name to better describe what the node does: adaptively blends guidance based on cosine similarity between positive and negative conditions. Amp-Thread-ID: https://ampcode.com/threads/T-019c0d36-8b43-745f-b7b2-e35b53f17fa1 Co-authored-by: Amp <amp@ampcode.com>
christian-byrne
requested review from
Kosinkadink,
comfyanonymous and
guill
as code owners
Member
|
Could you add a search alias for the old name? For history's sake 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename the display name of the Mahiro node to better describe its functionality.
Changes
"Mahiro CFG"→"Similarity-Adaptive Guidance"to accurately describe the algorithm's behavior: adaptively blending between positive-only scaling and standard CFG based on cosine similarity between conditions.Context
The node was originally named with an anime reference. This rename follows ComfyUI's naming conventions (similar to "Adaptive Projected Guidance") and describes what the algorithm actually does.