Skip to content

Revert "Server: Robust shutdown on stdio detach (signals, stdin/paren… - #364

Merged
dsarno merged 1 commit into
CoplayDev:mainfrom
dsarno:revert/revert-shutdown
Nov 1, 2025
Merged

Revert "Server: Robust shutdown on stdio detach (signals, stdin/paren…#364
dsarno merged 1 commit into
CoplayDev:mainfrom
dsarno:revert/revert-shutdown

Conversation

@dsarno

@dsarno dsarno commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator

…t monitor, forced exit) (#363)"

This reverts commit ca01fc7. User reported connection error, will test further before trying again.

Summary by CodeRabbit

  • Chores

    • Simplified server startup and shutdown process by removing complex threading and signal handling mechanisms. The server now directly invokes the MCP stdio transport for more straightforward operation.
  • Tests

    • Added new telemetry validation tests to verify telemetry recording and configuration functionality.
    • Removed legacy telemetry server test suite.
@coderabbitai

coderabbitai Bot commented Nov 1, 2025

Copy link
Copy Markdown
Contributor

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between ca01fc7 and 15f699d.

📒 Files selected for processing (5)
  • MCPForUnity/UnityMcpServer~/src/server.py (1 hunks)
  • Server/server.py (1 hunks)
  • Server/test_telemetry.py (1 hunks)
  • UnityMcpBridge/UnityMcpServer~/src/server.py (1 hunks)
  • tests/test_telemetry_server.py (0 hunks)
 _______________________________________
< Preventing the Matrix from glitching. >
 ---------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dsarno
dsarno merged commit e4904ad into CoplayDev:main Nov 1, 2025
1 check was pending
@dsarno
dsarno deleted the revert/revert-shutdown branch November 7, 2025 00:15
choej2303 pushed a commit to choej2303/unity-mcp-ide that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant