Skip to content

fix: replace Editor-only McpLog with Debug.LogWarning in Runtime asse… #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsarno merged 1 commit into from
Jan 8, 2026
Merged

fix: replace Editor-only McpLog with Debug.LogWarning in Runtime asse… #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MCPForUnity/Runtime/Serialization/UnityTypeConverters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ public override UnityEngine.Object ReadJson(JsonReader reader, Type objectType,
#else
// Runtime deserialization is tricky without AssetDatabase/EditorUtility
// Maybe log a warning and return null or existingValue?
McpLog.Warn("UnityEngineObjectConverter cannot deserialize complex objects in non-Editor mode.");
UnityEngine.Debug.LogWarning("UnityEngineObjectConverter cannot deserialize complex objects in non-Editor mode.");
// Skip the token to avoid breaking the reader
if (reader.TokenType == JsonToken.StartObject) JObject.Load(reader);
else if (reader.TokenType == JsonToken.String) reader.ReadAsString();
Expand Down
15 changes: 0 additions & 15 deletions TestProjects/UnityMCPTests/Assets/Scripts/LongUnityScriptClaudeTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ private void LateUpdate()
}
}

// NL tests sometimes add comments above Update() as an anchor
// Build marker OK
private void Update()
{
if (reachOrigin == null) return;
Expand Down Expand Up @@ -757,19 +755,6 @@ private void Pad0239()
}
private void Pad0240()
{
// Tail test A
// Tail test B
// Tail test C
// idempotency test marker

void TestHelper() { /* placeholder */ }
void IncrementCounter() { padAccumulator++; }
// end of test modifications
// path test marker A




}
private void Pad0241()
{
Expand Down