[base] moving to buster slim - #374
Conversation
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
Let's get a review from container-integration as well
| DD_CONF_PROCFS_PATH="/host/proc" | ||
|
|
||
| # workaround for stretch-slim missing man dirs | ||
| RUN seq 1 8 | xargs -I{} mkdir -p /usr/share/man/man{} |
There was a problem hiding this comment.
I'm curious, why is this necessary?
There was a problem hiding this comment.
I actually have to check if it's still necessary with buster - on slim those directories are missing, I left it in there because it's a NOP if the directory structure is in place. Not having it in place was breaking the build with stretch-slim, it was a well documented issue.
CharlyF
left a comment
CharlyF
left a comment
There was a problem hiding this comment.
After reading about this issue in other repos I think this is the way forward.
They are recommending the same approach here debuerreotype/debuerreotype#10 (comment)
Thank you Jaime!
| @@ -1,4 +1,4 @@ | |||
| FROM debian:stretch | |||
| FROM debian:buster-20200607-slim | |||
There was a problem hiding this comment.
Why fixed date base? Using debian:buster-slim would be more aligned with what we do for Agent7
There was a problem hiding this comment.
Reproducible builds. I personally think this is better. But if you have a strong opinion let me know, we can fix in a follow-up PR.
4 participants
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
Updates the docker agent base image to use the more current buster slim
Motivation
More current, secure base image.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?