Skip to content

Fix XHR Test - #437

Merged
Xmader merged 6 commits into
mainfrom
caleb/fix/xhr-test
Sep 11, 2024
Merged

Fix XHR Test#437
Xmader merged 6 commits into
mainfrom
caleb/fix/xhr-test

Conversation

@zollqir

@zollqir zollqir commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

This test fixes the XHR test that often breaks in CI. This is accomplished by using a local server rather than a remote one we do not control

@zollqir zollqir self-assigned this Sep 11, 2024
@zollqir zollqir added this to the v1.0.0 milestone Sep 11, 2024
Comment thread tests/python/test_xhr.py

@Xmader Xmader left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xmader
Xmader merged commit e72bfd2 into main Sep 11, 2024
@Xmader
Xmader deleted the caleb/fix/xhr-test branch September 11, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants