Fix the Quickstart tutorial and make the docs refer to this repo instead of a fork#20
Merged
Conversation
Member
|
Thanks for the contribution! Could you separate the changes so that the pull request is atomic, i.e. doesn't do many things at once? Currently it contains the following changes:
Let me know if you have any questions :) The help is much appreciated! |
now uses GitHub version instead of local
testing and tutorial errored out for ImageClassification task. An `encode` function was added, equivalent to the one already existing for ImageSegmentation
Contributor
Author
|
I hope this satisfies your request. |
Removed extra `encode` method. This was fixed in DLPipelines.jl v0.2.0
Member
|
I've gone ahead and removed the |
Contributor
Author
|
So revert everything except the docs fix? |
Member
|
Should be the case now, I'll merge once the checks have run through 👍 |
Contributor
Author
|
I messed up the commit history. Should I clean it up and force push again? |
Member
|
You don't need to, I'll squash the commits down into one when I merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the erroring tests, as I removed the reference to a local DLPipelines or at least change the location of/reason for the error.