Skip to content

v2.19.2 - #2592

Merged
kevinmessiaen merged 2 commits into
v2from
release/v2.19.2
Jul 6, 2026
Merged

v2.19.2#2592
kevinmessiaen merged 2 commits into
v2from
release/v2.19.2

Conversation

@henchaves

Copy link
Copy Markdown
Member

Release v2.19.2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 2.19.2 in pyproject.toml and removes the dark-mode-only logo from the README.md. Feedback on the changes highlights that removing the dark-mode logo while retaining the #gh-light-mode-only fragment on the remaining logo will cause it to be hidden for users in dark mode; it is recommended to remove this fragment if the logo is intended to be displayed in both themes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread README.md
<p align="center">
<img alt="giskardlogo" src="https://raw.githubusercontent.com/giskard-ai/giskard/main/readme/giskard_logo.png#gh-light-mode-only">
<img alt="giskardlogo" src="https://raw.githubusercontent.com/giskard-ai/giskard/main/readme/giskard_logo_green.png#gh-dark-mode-only">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

By removing the dark-mode-only logo image while keeping the #gh-light-mode-only fragment on the remaining logo image, the logo will be completely hidden for users viewing the repository in GitHub's dark mode. If the intention is to use giskard_logo.png for both light and dark themes, please remove the #gh-light-mode-only fragment from its URL so that it displays in both modes.

@kevinmessiaen
kevinmessiaen merged commit 8651239 into v2 Jul 6, 2026
15 of 40 checks passed
@kevinmessiaen
kevinmessiaen deleted the release/v2.19.2 branch July 6, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants