Greenfield: Implement direct KRM types, identity, and generate.sh for NetworkConnectivityServiceConnectionMap by hopper-coder-bot · Pull Request #13340 · GoogleCloudPlatform/k8s-config-connector

hopper-coder-bot · 2026-09-21T08:41:47Z

This PR implements the direct KRM types, identity, and reference registration for NetworkConnectivityServiceConnectionMap under apis/networkconnectivity/v1alpha1.

This PR was generated by the overseer,overseer,step/gen-types,greenfield agent (powered by the gemini-3.7-flash model).

Fixes #13307

NONE

argus-watcher-bot · 2026-09-24T18:05:24Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

argus-watcher-bot · 2026-09-24T19:01:14Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

argus-watcher-bot · 2026-09-24T21:09:07Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

argus-watcher-bot · 2026-09-24T21:40:54Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

argus-watcher-bot · 2026-09-24T23:02:16Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

argus-watcher-bot · 2026-09-24T23:52:41Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

ldanielmadariaga · 2026-09-25T01:05:59Z

Fix merge conflicts

argus-watcher-bot · 2026-09-25T01:28:45Z

🤖 AI Factory started addressing review feedback for this pull request.

hopper-coder-bot · 2026-09-25T03:22:10Z

Rebased branch onto latest upstream master and resolved merge conflicts in apis/networkconnectivity/generate.sh, generated types/mappers, and pkg/gcpurls/registry_test.go. Validated formatting and tests cleanly.

(This comment was generated by overseer)

argus-watcher-bot · 2026-09-26T03:37:28Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

ldanielmadariaga · 2026-09-29T22:18:47Z

+type ConsumerPSCConfig struct {
+	// Required. The project ID or project number of the consumer project. This project is the one that the consumer uses to interact with the producer instance. From the perspective of a consumer who's created a producer instance, this is the project of the producer instance. Format: 'projects/' Eg. 'projects/consumer-project' or 'projects/1234'
+	// +kcc:proto:field=mockgcp.cloud.networkconnectivity.v1.ConsumerPscConfig.consumer_instance_project
+	ConsumerInstanceProject *string `json:"consumerInstanceProject,omitempty"`


Should be a projectRef

ldanielmadariaga · 2026-09-29T22:19:29Z

+
+	// Immutable. Deprecated. Use producer_instance_metadata instead. An immutable identifier for the producer instance.
+	// +kcc:proto:field=mockgcp.cloud.networkconnectivity.v1.ConsumerPscConfig.producer_instance_id
+	ProducerInstanceID *string `json:"producerInstanceID,omitempty"`


This field is deprecated let's ignore it: https://docs.cloud.google.com/network-connectivity/docs/reference/networkconnectivity/rest/v1/projects.locations.serviceConnectionMaps#consumerpscconfig

ldanielmadariaga · 2026-09-29T22:20:51Z

+
+	// The consumer project where PSC connections are allowed to be created in.
+	// +kcc:proto:field=mockgcp.cloud.networkconnectivity.v1.ConsumerPscConfig.project
+	Project *string `json:"project,omitempty"`


I think this also needs to be a projectRef unless project means something else in this context, given consumerInstanceProject I don't believe it does.

argus-watcher-bot · 2026-09-29T22:24:56Z

🤖 AI Factory started addressing review feedback for this pull request.

… NetworkConnectivityServiceConnectionMap This PR implements the direct KRM types, identity, and reference registration for NetworkConnectivityServiceConnectionMap. Fixes GoogleCloudPlatform#13307 Generated-by: overseer,overseer,step/gen-types,greenfield,overseer/review (gemini-3.7-flash) release-note: ```release-note NONE ```

hopper-coder-bot · 2026-09-30T00:11:10Z

Thank you for the review! I have addressed the feedback:

automatedDNSCreationSpec on ProducerPSCConfig: The automated_dns_creation_spec field is present in the upstream google.cloud.networkconnectivity.v1 protobuf schema (which our proto models and code generators build from). The REST documentation pages occasionally omit newer proto additions, but this is an active v1 proto feature rather than a deprecated field.
consumerInstanceProject on ConsumerPSCConfig: Updated to consumerInstanceProjectRef of type *refsv1beta1.ProjectRef.
producerInstanceID on ConsumerPSCConfig: Removed the deprecated producerInstanceID field.
project on ConsumerPSCConfig: Updated to projectRef of type *refsv1beta1.ProjectRef.

Regenerated CRDs, deepcopy functions, direct mappers, and updated missing field exceptions.

(This comment was generated by overseer)

google-oss-prow · 2026-09-30T00:11:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ldanielmadariaga. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

argus-watcher-bot · 2026-09-30T00:28:20Z

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

hopper-coder-bot · 2026-09-30T00:33:55Z

Investigating tests-e2e-fixtures-containeranalysis failure

Run: 36649064450
Name: tests-e2e-fixtures-containeranalysis
Cause: Infrastructure
Details: The job failed during envtest asset download with unable fetch envtest-v1.37.0-linux-amd64.tar.gz (https://github.com/kubernetes-sigs/controller-tools/releases/download/envtest-v1.37.0/envtest-v1.37.0-linux-amd64.tar.gz) -- got status "500 Internal Server Error", which led to exec: "etcd": executable file not found in $PATH. This is an external infrastructure flake unrelated to the PR changes.
Action Taken: Rerun triggered

Investigating tests-e2e-fixtures-apihub failure

Run: 36649064450
Name: tests-e2e-fixtures-apihub
Cause: Infrastructure
Details: The job failed during envtest asset download with unable fetch envtest-v1.37.0-linux-amd64.tar.gz (https://github.com/kubernetes-sigs/controller-tools/releases/download/envtest-v1.37.0/envtest-v1.37.0-linux-amd64.tar.gz) -- got status "500 Internal Server Error". This is an external infrastructure flake unrelated to the PR changes.
Action Taken: Rerun triggered

Investigating tests-e2e-fixtures-developerconnect failure

Run: 36649064450
Name: tests-e2e-fixtures-developerconnect
Cause: Infrastructure
Details: The job failed during envtest asset download with unable fetch envtest-v1.37.0-linux-amd64.tar.gz (https://github.com/kubernetes-sigs/controller-tools/releases/download/envtest-v1.37.0/envtest-v1.37.0-linux-amd64.tar.gz) -- got status "500 Internal Server Error". This is an external infrastructure flake unrelated to the PR changes.
Action Taken: Rerun triggered

(This report was generated by overseer)

ldanielmadariaga · 2026-10-01T02:43:18Z

+type NetworkConnectivityServiceConnectionMapObservedState struct {
+	// Output only. PSC connection details on consumer side.
+	// +optional
+	ConsumerPSCConnections []ConsumerPSCConnection `json:"consumerPSCConnections,omitempty"`


Should we call these ConsumerPSCConnectionObservedState or given they are already contained in an *ObservedState object this is already fine as is?

argus-watcher-bot · 2026-10-01T02:46:00Z

🤖 AI Factory started addressing review feedback for this pull request.

hopper-coder-bot · 2026-10-01T03:31:04Z

Thanks for the feedback!

Regarding ConsumerPSCConnection:
Leaving it as ConsumerPSCConnection is standard and fine as is. In KCC and controllerbuilder, sub-structs that map 1:1 to a proto message (here mockgcp.cloud.networkconnectivity.v1.ConsumerPscConnection) are generated under their canonical Go type name ConsumerPSCConnection in types.generated.go. An *ObservedState suffix is typically only applied when a proto message is split between Spec and Status or for the top-level resource ObservedState struct (NetworkConnectivityServiceConnectionMapObservedState). Since ConsumerPSCConnection is already contained within NetworkConnectivityServiceConnectionMapObservedState, keeping ConsumerPSCConnection aligns with the generated code and repository conventions.

(This comment was generated by overseer)

hopper-coder-bot added overseer step/gen-types greenfield Indicates implementation of a new resource (vs migration) labels Sep 21, 2026

argus-watcher-bot added overseer/ready-for-human and removed overseer/ready-for-human labels Sep 21, 2026

hopper-coder-bot force-pushed the issue-13307-1789976053 branch from 5345e1b to 9b5ab6c Compare September 25, 2026 03:22

argus-watcher-bot added overseer/ready-for-human and removed overseer/ready-for-human labels Sep 25, 2026

hopper-coder-bot force-pushed the issue-13307-1789976053 branch from 9b5ab6c to 5c2a3cf Compare September 26, 2026 04:31

argus-watcher-bot added the overseer/ready-for-human label Sep 26, 2026

walle-agent-bot mentioned this pull request Sep 28, 2026

ai:feat: KCC support for NetworkConnectivityServiceConnectionMap #13273

Open

ldanielmadariaga requested changes Sep 29, 2026

View reviewed changes

google-oss-prow Bot assigned ldanielmadariaga Sep 29, 2026

hopper-coder-bot force-pushed the issue-13307-1789976053 branch from 5c2a3cf to ad3d50f Compare September 30, 2026 00:11

ldanielmadariaga reviewed Oct 1, 2026

View reviewed changes

Navigation Menu

Greenfield: Implement direct KRM types, identity, and generate.sh for NetworkConnectivityServiceConnectionMap - #13340

Greenfield: Implement direct KRM types, identity, and generate.sh for NetworkConnectivityServiceConnectionMap#13340
hopper-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
hopper-coder-bot:issue-13307-1789976053

hopper-coder-bot commented Sep 21, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

ldanielmadariaga commented Sep 25, 2026

argus-watcher-bot commented Sep 25, 2026

hopper-coder-bot commented Sep 25, 2026

argus-watcher-bot commented Sep 26, 2026

Uh oh!

ldanielmadariaga Sep 29, 2026

ldanielmadariaga Sep 29, 2026

ldanielmadariaga Sep 29, 2026

argus-watcher-bot commented Sep 29, 2026

hopper-coder-bot commented Sep 30, 2026

google-oss-prow Bot commented Sep 30, 2026

argus-watcher-bot commented Sep 30, 2026

hopper-coder-bot commented Sep 30, 2026

ldanielmadariaga Oct 1, 2026

argus-watcher-bot commented Oct 1, 2026

hopper-coder-bot commented Oct 1, 2026

This branch has not been deployed

Labels

3 participants

Conversation

hopper-coder-bot commented Sep 21, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

argus-watcher-bot commented Sep 24, 2026

ldanielmadariaga commented Sep 25, 2026

argus-watcher-bot commented Sep 25, 2026

hopper-coder-bot commented Sep 25, 2026

argus-watcher-bot commented Sep 26, 2026

Uh oh!

ldanielmadariaga Sep 29, 2026

Choose a reason for hiding this comment

ldanielmadariaga Sep 29, 2026

Choose a reason for hiding this comment

ldanielmadariaga Sep 29, 2026

Choose a reason for hiding this comment

argus-watcher-bot commented Sep 29, 2026

hopper-coder-bot commented Sep 30, 2026

google-oss-prow Bot commented Sep 30, 2026

argus-watcher-bot commented Sep 30, 2026

hopper-coder-bot commented Sep 30, 2026

Investigating tests-e2e-fixtures-containeranalysis failure

Investigating tests-e2e-fixtures-apihub failure

Investigating tests-e2e-fixtures-developerconnect failure

ldanielmadariaga Oct 1, 2026

Choose a reason for hiding this comment

argus-watcher-bot commented Oct 1, 2026

hopper-coder-bot commented Oct 1, 2026

This branch has not been deployed

Labels

3 participants