Greenfield: Support BigQueryReservationBiReservation - #13409
lovelace-coder-bot wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🤖 AI Factory started investigating CI check failures for this pull request. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
Investigating Validate PR Release Note failureRun: 35903132399 (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
…or BigQueryReservationBiReservation (GoogleCloudPlatform#13379) This PR implements the direct controller, types, identity, and MockGCP handlers for the BigQueryReservationBiReservation singleton resource. Issue: 13379
e77a5fc to
0f59867
Compare
Investigating unit-tests-2-of-4 failureRun: 35903131858 Investigating presubmit-gatekeeper failureRun: 35903131858 (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
Investigating tests-e2e-fixtures-cloudidentity failureRun: 35924037618 Investigating presubmit-gatekeeper failureRun: 35924037618 (This report was generated by overseer) |
Greenfield: Support BigQueryReservationBiReservation
This PR implements Greenfield KRM types, identity, controller, mock, and test fixtures for
BigQueryReservationBiReservation(bigqueryreservation.cnrm.cloud.google.com/v1alpha1).Fixes #13379
BRIEF Change description
BigQueryReservationBiReservationto thegenerate-typescommand underv1alpha1group-version.apis/bigqueryreservation/v1alpha1/bigqueryreservationbireservation_types.go): Scaffolded the spec and status schemas, adding proper annotations, validation, and documentation fields.apis/bigqueryreservation/v1alpha1/bigqueryreservationbireservation_identity.go): ImplementedBigQueryReservationBiReservationIdentityusing the canonicalgcpurls.Templateandidentity.IdentityV2patterns.apis/bigqueryreservation/v1alpha1/bigqueryreservationbireservation_identity_test.go): Wrote 100% successful unit tests validating format parsing and spec identity resolution.pkg/controller/direct/bigqueryreservation/bigqueryreservationbireservation_controller.go): Implemented thedirectbase.Modelanddirectbase.Adapterreconcilers forBigQueryReservationBiReservation. Added singleton handling (Get + Update pattern) with diff mask updates.mockgcp/mockbigqueryreservation/reservation.go): Added mock handlers forGetBiReservationandUpdateBiReservation.pkg/controller/resourceconfig/static_config.go): RegisteredBigQueryReservationBiReservationas a direct-only controller.pkg/test/resourcefixture/testdata/basic/bigqueryreservation/v1alpha1/bigqueryreservationbireservation/): Scaffolded the initial basic test manifests.This PR was generated by the overseer,enhancement,overseer agent (powered by the gemini-3.7-flash model).
Does this PR add something which needs to be 'release noted'?