Skip to content

Greenfield: Implement direct KRM types, identity, and generate.sh for DiscoveryEngineSchema - #13446

Open
neumann-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
neumann-coder-bot:issue-12017-1790317961
Open

neumann-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
neumann-coder-bot:issue-12017-1790317961

Conversation

@neumann-coder-bot

@neumann-coder-bot neumann-coder-bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

BRIEF Change description

Greenfield: Implement direct KRM types, identity, reference, and generate.sh for DiscoveryEngineSchema.

Fixes #12017

WHY do we need this change?

Adds Greenfield direct KRM types and CRD for DiscoveryEngineSchema.

Special notes for your reviewer:

This PR was generated by the overseer,step/gen-types,greenfield,overseer/review agent (powered by the gemini-3.7-flash model).

Does this PR add something which needs to be 'release noted'?

NONE

Additional documentation e.g., references, usage docs, etc.:


Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.
@neumann-coder-bot neumann-coder-bot added overseer step/gen-types greenfield Indicates implementation of a new resource (vs migration) overseer/review labels Sep 25, 2026
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating Validate PR Release Note failure

Run: 36106472257
Name: Validate PR Release Note
Cause: Code Error
Details: The PR description was missing the required release-note block.
Action Taken: Updated the PR description with the template release-note block set to NONE.

Investigating validate-fmt failure

Run: 36106472348
Name: validate-fmt
Cause: Code Error
Details: pkg/controller/resourceconfig/static_config.go was not properly formatted according to gofmt.
Action Taken: Ran make fmt, formatted pkg/controller/resourceconfig/static_config.go, amended the commit, and pushed the updated branch.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating unit-tests-2-of-4 failure

Run: 36111177853
Name: unit-tests-2-of-4
Cause: Test Failure
Details: TestCRDFieldPresenceInTestsForAlpha failed due to an unexpected diff in tests/apichecks/testdata/exceptions/alpha-missingfields.txt for the new DiscoveryEngineSchema CRD field (.spec.structSchema).
Action Taken: Updated tests/apichecks/testdata/exceptions/alpha-missingfields.txt, amended the commit, and pushed the updated branch.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating tests-e2e-fixtures-networksecurity failure

Run: 36120089096
Name: tests-e2e-fixtures-networksecurity
Cause: Flake
Details: The e2e fixture test urllist-maximal failed due to an unexpected diff in HTTP calls (google.cloud.networksecurity.v1.NetworkSecurity/GetUrlList: mismatched number of HTTP calls: want 4, got 3), which is a timing/poll flake unrelated to the changes in this PR (DiscoveryEngineSchema).
Action Taken: Triggered a rerun of the failed workflow job (gh run rerun 36120089096 --failed).

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started reviewing this pull request in a sandbox.

@reviewbot-robot reviewbot-robot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KCC Auto-Review Results

  • Trigger criteria matched: Yes
  • API Version Check: Pass - Types are placed in apis/discoveryengine/v1alpha1/ and CRD version is v1alpha1.
  • Go Type Pointers: Pass - All scalar primitive fields (Location, JsonSchema, ResourceID, ObservedGeneration, ExternalRef) are properly defined as pointers.
  • Completeness & Heuristics: Pass - Fields from google.cloud.discoveryengine.v1.Schema (struct_schema, json_schema, name) are correctly mapped to Spec and Identity.
  • 1:1 Kind to Proto Mapping: Pass - DiscoveryEngineSchema maps 1:1 to google.cloud.discoveryengine.v1.Schema.
  • References/Identity: Pass - Resource references (ProjectRef, DataStoreRef) and IdentityV2 implementation follow established patterns and conventions.
  • Exception Files: Pass - Only tests/apichecks/testdata/exceptions/alpha-missingfields.txt was modified.

Detailed Findings / Actions Required:

None. All checks passed.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started addressing review feedback for this pull request.

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

Thank you for the review! All auto-review checks and presubmit CI tests have passed with no further actions required.

(This comment was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

Implement direct KRM types, identity, reference, and CRD for DiscoveryEngineSchema.

Fixes GoogleCloudPlatform#12017

Issue: 12017

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenfield Indicates implementation of a new resource (vs migration) overseer/ready-for-human overseer step/gen-types

3 participants