Greenfield: Implement direct KRM types, identity, and generate.sh for DiscoveryEngineSchema - #13446
neumann-coder-bot wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🤖 AI Factory started investigating CI check failures for this pull request. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
b2f4810 to
7cb50dd
Compare
Investigating Validate PR Release Note failureRun: 36106472257 Investigating validate-fmt failureRun: 36106472348 (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
7cb50dd to
0f791a7
Compare
Investigating unit-tests-2-of-4 failureRun: 36111177853 (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
Investigating tests-e2e-fixtures-networksecurity failureRun: 36120089096 (This report was generated by overseer) |
|
🤖 AI Factory started reviewing this pull request in a sandbox. |
reviewbot-robot
left a comment
There was a problem hiding this comment.
KCC Auto-Review Results
- Trigger criteria matched: Yes
- API Version Check: Pass - Types are placed in
apis/discoveryengine/v1alpha1/and CRD version isv1alpha1. - Go Type Pointers: Pass - All scalar primitive fields (
Location,JsonSchema,ResourceID,ObservedGeneration,ExternalRef) are properly defined as pointers. - Completeness & Heuristics: Pass - Fields from
google.cloud.discoveryengine.v1.Schema(struct_schema,json_schema,name) are correctly mapped to Spec and Identity. - 1:1 Kind to Proto Mapping: Pass -
DiscoveryEngineSchemamaps 1:1 togoogle.cloud.discoveryengine.v1.Schema. - References/Identity: Pass - Resource references (
ProjectRef,DataStoreRef) and IdentityV2 implementation follow established patterns and conventions. - Exception Files: Pass - Only
tests/apichecks/testdata/exceptions/alpha-missingfields.txtwas modified.
Detailed Findings / Actions Required:
None. All checks passed.
|
🤖 AI Factory started addressing review feedback for this pull request. |
|
Thank you for the review! All auto-review checks and presubmit CI tests have passed with no further actions required. (This comment was generated by overseer) |
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
Implement direct KRM types, identity, reference, and CRD for DiscoveryEngineSchema. Fixes GoogleCloudPlatform#12017 Issue: 12017
0f791a7 to
e126a72
Compare
BRIEF Change description
Greenfield: Implement direct KRM types, identity, reference, and generate.sh for DiscoveryEngineSchema.
Fixes #12017
WHY do we need this change?
Adds Greenfield direct KRM types and CRD for DiscoveryEngineSchema.
Special notes for your reviewer:
This PR was generated by the overseer,step/gen-types,greenfield,overseer/review agent (powered by the gemini-3.7-flash model).
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Tests you have done
make ready-prto ensure this PR is ready for review.