Skip to content

mockgcp: match real GCP behavior for NetworkServicesEdgeCacheService - #13448

Open
hopper-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
hopper-coder-bot:issue-10658-1790318032
Open

hopper-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
hopper-coder-bot:issue-10658-1790318032

Conversation

@hopper-coder-bot

@hopper-coder-bot hopper-coder-bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

This PR implements MockGCP support for networkservices.EdgeCacheService (and supporting resources NetworkServicesEdgeCacheOrigin and NetworkServicesEdgeCacheKeyset) to match real GCP behavior and unblock test golden log matching.

Changes

  1. Mock Proto & Handlers: Defined mockgcp/apis/mockgcp/cloud/networkservices/v1/edge_cache.proto and generated gRPC server interfaces and grpc-gateway reverse-proxy handlers for EdgeCacheServicesServer, EdgeCacheOriginsServer, and EdgeCacheKeysetsServer.
  2. Mock Implementation:
    • Implemented CRUD and LRO handling in mocknetworkservices (mockgcp/mocknetworkservices/edgecacheservice.go, edgecacheorigin.go, edgecachekeyset.go).
    • Aligned default route configuration, origin expansion to full canonical path projects/${projectNumber}/locations/global/edgeCacheOrigins/${origin}, and default IP allocations to match authentic real GCP responses.
  3. Ratcheting: Removed NetworkServicesEdgeCacheService from SkipGoldenMatching in tests/e2e/ratcheting.go.
  4. Journal: Added journal entry under .gemini/skills/add-new-mockgcp-resource/journal/networkservicesedgecacheservice.md.

Fixes #10658

NONE

This PR was generated by the overseer agent (powered by the gemini-3.7-flash model).

@hopper-coder-bot hopper-coder-bot added overseer direct-migration Label for direct migration PRs. Will trigger direct migration specific checks. labels Sep 25, 2026
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ldanielmadariaga for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

@hopper-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating Validate PR Release Note failure

Run: 36114915841
Name: Validate PR Release Note
Cause: Code Error
Details: The PR description was missing the required release-note code block. Action Taken: Updated the PR description to include the release-note block specifying NONE. The subsequent workflow run triggered by the PR update succeeded (Run 36116581232).

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

Implement mock service, proto definitions, and gRPC gateway handlers for
NetworkServices EdgeCacheService, EdgeCacheOrigin, and EdgeCacheKeyset to
match real GCP behavior and remove EdgeCacheService from ratcheting skip list.

Issue: GoogleCloudPlatform#10658
@hopper-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating Validate PR Release Note failure

Run: 36114915841
Name: Validate PR Release Note
Cause: Infrastructure
Details: The original check run 36114915841 failed because the initial PR body created at PR open time did not contain the release-note block. Although the PR body was subsequently updated with release-note NONE``` (and passed on run 36116581232), rerunning run 36114915841 evaluated against the static initial event payload snapshot and remained failed in the commit check rollup.
Action Taken: Re-pushed the branch to synchronize the check suite on a fresh commit SHA. Validate PR Release Note has succeeded on the new commit (Run 36133031499).

(This report was generated by overseer)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direct-migration Label for direct migration PRs. Will trigger direct migration specific checks. overseer/ready-for-human overseer

2 participants