Conversation
The root .gitignore has an unanchored `log`, which matches pkg/cli/log. With no .gcloudignore, `gcloud builds submit` falls back to .gitignore and leaves that package out of the upload, so the Go build fails with "no required module provides package .../pkg/cli/log". Ship a .gcloudignore next to the runbook and pass it with --ignore-file. Found and fixed by the gke-std run against GoogleCloudPlatform#13497 (deploy verified).
sdowell
approved these changes
Sep 29, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sdowell The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
.gitignorehas an unanchoredlog, which also matchespkg/cli/log. The repo has no.gcloudignore, sogcloud builds submitfalls back to.gitignorerules and leaves that package out of the upload. The Cloud Build step then fails with:This change:
.agents/runbooks/gke-std/.gcloudignore, which uses an anchored/log;--ignore-file="${RUN_DIR}/.gcloudignore"indeploy.sh;runbook.mdto match.These are the changes from the
gke-stdrun's deploy commit (barney-s/k8s-config-connector@2e475fb). That run deployed #13497 from this runbook and reported it VERIFIED: images built,cnrm-systempods Ready, and the test PubSubTopic Ready.