Greenfield: Implement direct KRM types, identity, and generate.sh for SaaSServiceMgmtUnit - #13625
neumann-coder-bot wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🤖 AI Factory started investigating CI check failures for this pull request. Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored. |
…ference Implement direct KRM types, identity, reference, and generate.sh for SaaSServiceMgmtUnit. Issue: 13605
f252ef6 to
fa02fa2
Compare
Investigating unit-tests-2-of-4 failureRun: 36947566188 (This report was generated by overseer) |
|
🤖 AI Factory started reviewing this pull request in a sandbox. |
reviewbot-robot
left a comment
There was a problem hiding this comment.
KCC Auto-Review Results
- Trigger criteria matched: Yes
- API Version Check: Pass - (CRD and Go types correctly placed under
apis/saasservicemgmt/v1alpha1/asv1alpha1) - Go Type Pointers: Pass - (All Go scalar primitive fields including
Locationuse pointers; collection types are non-pointer slices) - Completeness & Heuristics: Pass - (All fields from
google.cloud.saasplatform.saasservicemgmt.v1beta1.Unitare 100% accounted for, with output-only fields properly mapped toObservedState) - 1:1 Kind to Proto Mapping: Pass - (1:1 relationship between
SaaSServiceMgmtUnitandUnitproto) - References/Identity: Pass - (Implemented
IdentityV2andrefs.Refusingrefs.Normalizeandgcpurls.Template) - Exception Files: Pass - (Only updated
tests/apichecks/testdata/exceptions/alpha-missingfields.txt)
Detailed Findings / Actions Required:
None. All review criteria and conventions for greenfield new types are met.
|
🤖 AI Factory started addressing review feedback for this pull request. |
|
All automated checks and review criteria have passed with no findings or required actions. The PR is clean and ready for review/merge. (This comment was generated by overseer) |
Description
This PR implements direct KRM types, identity, reference, and
generate.shfor theSaaSServiceMgmtUnitgreenfield resource (saasservicemgmt.cnrm.cloud.google.com/v1alpha1).Key Changes
SaaSServiceMgmtUnitSpecandSaaSServiceMgmtUnitObservedStateinapis/saasservicemgmt/v1alpha1/saasservicemgmtunit_types.go.google.cloud.saasplatform.saasservicemgmt.v1beta1.Unitproto.location,unitKind,tenant,managementMode) with CEL rules.SaaSServiceMgmtUnitIdentityadhering toidentity.IdentityV2andidentity.Resourceinterfaces inapis/saasservicemgmt/v1alpha1/saasservicemgmtunit_identity.go.SaaSServiceMgmtUnitRefadhering torefs.Refusingrefs.Normalizeinapis/saasservicemgmt/v1alpha1/saasservicemgmtunit_reference.go.apis/saasservicemgmt/v1alpha1/saasservicemgmtunit_identity_test.go.apis/saasservicemgmt/generate.shto include--resource SaaSServiceMgmtUnit:Unit.Fixes #13605
This PR was generated by the overseer,step/gen-types,greenfield,overseer/review agent (powered by the gemini-3.7-flash model).