Conversation
neumann-coder-bot
added
overseer
step/mockgcp
greenfield
barney-s
approved these changes
Oct 2, 2026
barney-s
left a comment
barney-s
left a comment
Collaborator
There was a problem hiding this comment.
/lgtm
/approve
no-op refactor change
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
via the queue into
GoogleCloudPlatform:master
with commit Oct 2, 2026
eec278a
258 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR verifies and aligns the MockGCP logs and behavior with RealGCP for
EventarcPipeline(eventarc.cnrm.cloud.google.com/v1alpha1).Key Changes
populateDefaultsForPipelineinmockgcp/mockeventarc/pipeline.gointo a helper method for consistent MockGCP defaulting structure.EventarcPipelinefixtures (eventarcpipeline-minimalandeventarcpipeline-maximal) passTestGoldenLogAlignmentand E2E mock tests with 0 errors.Fixes #13659
This PR was generated by the overseer,step/mockgcp,greenfield agent (powered by the gemini-3.7-flash model).