Skip to content

docs: remove antipatterns in top-level GEMINI.md - #13667

Merged
barney-s merged 1 commit into
GoogleCloudPlatform:masterfrom
neumann-coder-bot:issue-13662-1790965488
Oct 3, 2026
Merged

barney-s merged 1 commit into
GoogleCloudPlatform:masterfrom
neumann-coder-bot:issue-13662-1790965488

Conversation

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator

Description

This PR cleans up anti-patterns in the top-level GEMINI.md to optimize agent context efficiency and adhere to modular skill architecture.

Key Changes

  1. Procedural Coding & Validation Routines: Removed prescriptive procedural workflows (make fmt, go vet ./..., presubmit scripts list, custom linter inner logic, manual pre-push steps, and procedural cat | yq resource extraction command) which are now handled by skills and tooling hooks.
  2. Tool-Specific Operational Commands: Removed hardcoded global CLI execution rules (gh issue).
  3. Task-Specific Documentation Routing: Removed dead document lists and script catalogues (docs/ai/..., dev/tasks/...) in favor of dynamic discovery via .gemini/skills/.
  4. Temporal Rules: Removed the static copyright header section.

Fixes #13662

NONE

This PR was generated by the overseer,priority/critical agent (powered by the gemini-3.7-flash model).

Comment thread GEMINI.md
# Task-Specific Docs

* `mockgcp/GEMINI.md` provides detailed expert guidance on aligning mock behavior with real GCP APIs.
* `docs/ai/qualify-alpha-for-beta.md` shares tips on how to qualify alpha resources for beta promotion.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these docs best left as skills ? If so can we create skills

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started addressing review feedback for this pull request.

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

Yes, converting these procedural docs into modular skills keeps GEMINI.md lean while retaining actionable guidance for agents.

I have created three new skills under .gemini/skills/:

  1. promote-resource-to-beta: Guides qualifying alpha resources and promoting CRDs, controllers, and test fixtures from v1alpha1 to v1beta1 (including import aliasing conventions).
  2. generate-ci-presubmit-workflow: Guides adding per-service presubmit test scripts and regenerating .github/workflows/ci-presubmit.yaml.
  3. run-presubmits-and-linters: Guides running and debugging CI presubmits locally, updating golden output with WRITE_GOLDEN_OUTPUT=1, and understanding custom linters like jsonunmarshalreuse.

(This comment was generated by overseer)

Comment thread GEMINI.md
When promoting a resource from `v1alpha1` to `v1beta1`, we should keep `krm` as the import alias for `v1alpha1` and use `krmv1beta1` for `v1beta1`. This is to minimize the code changes.


# Task-Specific Docs

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can each of these task specific docs become skills ? if so lets make them skills and remove these task specific docs.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started addressing review feedback for this pull request.

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

All procedural and task-specific guides previously under docs/ai/ and mockgcp/docs/ai/ have now been converted into modular skills under .gemini/skills/, and the obsolete task-specific documentation files have been deleted:

  • docs/ai/qualify-alpha-for-beta.md and docs/ai/how-to-promote-resource.md -> .gemini/skills/promote-resource-to-beta/
  • docs/ai/github-workflow.md -> .gemini/skills/generate-ci-presubmit-workflow/
  • docs/ai/add-missing-field.md -> .gemini/skills/add-missing-field/
  • docs/ai/create-crd-for-existing-terraform-resource.md -> .gemini/skills/crd-mapper-fuzzer-existing-type/ & kcc-direct-brownfield-types-implementer/
  • docs/ai/add-crd-mapper-fuzzer.md & docs/ai/implement-fuzzer-field.md & docs/ai/unify-api-mapper-fuzzer.md -> .gemini/skills/create-mapper-fuzzer/ & create-fuzzer/
  • docs/ai/add-direct-controller.md -> .gemini/skills/create-direct-controller/ & kcc-direct-controller-implementer/
  • docs/ai/add-resource-references.md & docs/ai/coderefactoring-plan-for-identity-parent.md -> .gemini/skills/kcc-identity-reference/
  • docs/ai/handle-labels-for-direct-resource.md -> .gemini/skills/kcc-direct-brownfield-labels/
  • docs/ai/server-generated-id.md -> .gemini/skills/kcc-direct-service-generated-id/
  • mockgcp/docs/ai/create-mockgcp.md -> .gemini/skills/add-new-mockgcp-resource/ & match-mockgcp-with-realgcp/
  • General developer docs (overseer-developer-guide.md) have been relocated to docs/overseer-developer-guide.md.

All dangling doc comments and references across the codebase have also been updated to point directly to the corresponding skills.

(This comment was generated by overseer)

@barney-s barney-s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

synced with @maqiuyujoyce

@barney-s
barney-s added this pull request to the merge queue Oct 3, 2026
@google-oss-prow google-oss-prow Bot added the lgtm label Oct 3, 2026
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 3, 2026
@barney-s
barney-s added this pull request to the merge queue Oct 3, 2026
Merged via the queue into GoogleCloudPlatform:master with commit bb99b67 Oct 3, 2026
255 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment