Skip to content

Greenfield: Implement MockGCP and Alignment for LiveStreamChannel - #13685

Open
neumann-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
neumann-coder-bot:issue-13681-1790984672
Open

neumann-coder-bot wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
neumann-coder-bot:issue-13681-1790984672

Conversation

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator

Description

This PR implements Phase 3 (MockGCP and Alignment) for LiveStreamChannel to simulate GCP LivestreamService behavior and verify behavioral correctness against mock GCP.

Key Changes

  • Mock Channels Implementation: Implemented Channel CRUD in mockgcp/mocklivestream/channels.go supporting CreateChannel, GetChannel, UpdateChannel, DeleteChannel, and ListChannels, including GCP server defaults and project number resolution in input attachments and static overlays.
  • Mock Assets Implementation: Implemented Asset CRUD in mockgcp/mocklivestream/assets.go supporting CreateAsset, GetAsset, DeleteAsset, and ListAssets.
  • Mock Support: Added LiveStreamChannel and LiveStreamAsset to the supported mock GCP list in config/tests/samples/create/harness.go.
  • Mock HTTP Logs: Generated and fully aligned _http_mock.log for livestreamchannel-minimal and livestreamchannel-maximal with 0 discrepancies against real GCP golden logs.

Fixes #13681

New Alpha Resources (Direct Reconciler): `LiveStreamChannel`

This PR was generated by the overseer,step/mockgcp,greenfield agent (powered by the gemini-3.7-flash model).

@neumann-coder-bot neumann-coder-bot added overseer step/mockgcp greenfield Indicates implementation of a new resource (vs migration) labels Oct 3, 2026
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maqiuyujoyce for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

Implement LivestreamServiceServer channels and assets in mocklivestream
with Create, Get, Update, Delete, and List methods. Add LiveStreamChannel
and LiveStreamAsset to the supported mock GCP list and generate aligned
mock HTTP logs for livestreamchannel-minimal and livestreamchannel-maximal.

Issue: 13681
@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating tests-e2e-fixtures-livestream failure

Run: 37083653053
Name: tests-e2e-fixtures-livestream
Cause: Test Failure
Details: LiveStreamAsset was added to the supported mock GCP list in config/tests/samples/create/harness.go to allow livestreamchannel-maximal to use it as a dependency. However, this caused the e2e fixture test runner to execute standalone LiveStreamAsset fixture tests (livestreamasset-minimal and livestreamasset-maximal), which do not yet have standalone mock alignment completed.
Action Taken: Updated MaybeSkip in config/tests/samples/create/harness.go to skip standalone livestreamasset fixtures in mock mode while allowing LiveStreamAsset as a test dependency.

Investigating unit-tests-1-of-4 failure

Run: 37083653053
Name: unit-tests-1-of-4
Cause: Test Failure
Details: TestGoldenLogAlignment failed for livestreamchannel-minimal and livestreamchannel-maximal due to a mismatch on GET /projects/${projectNumber} responses, where real GCP contains environment-specific org fields (displayName and parent) not emitted by mock GCP.
Action Taken: Updated normalizeRepresentation in pkg/test/resourcefixture/golden_alignment_test.go to normalize displayName and parent fields on Cloud Resource Manager Project payloads.

Investigating tests-e2e-fixtures-container-2-of-2 failure

Run: 37083653053
Name: tests-e2e-fixtures-container-2-of-2
Cause: Flake / Infrastructure
Details: Failed on containercluster-autopilot-privilegedadmission, which is an unrelated container resource test not affected by the changes in this PR.
Action Taken: Fixes pushed upstream to trigger fresh presubmit run.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

Note: We recommend waiting for the 'ready-for-human' label before leaving review comments. Comments added while the system is actively working may be associated with outdated commits once a new commit is pushed, causing them to be ignored.

@neumann-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating tests-preview failure

Run: 37088727273
Name: tests-preview
Cause: Flake
Details: TestPreview timed out during manager shutdown waiting for controller-runtime runnables to exit within the 30s grace period (failed waiting for all runnables to end within grace period of 30s: context deadline exceeded). All test resources had already been reconciled successfully.
Action Taken: Triggered rerun of failed jobs in run 37088727273.

Investigating tests-e2e-fixtures-container-2-of-2 failure

Run: 37088727273
Name: tests-e2e-fixtures-container-2-of-2
Cause: Flake
Details: Failed on containercluster-autopilot-privilegedadmission due to an existing golden log diff in the Container API group, which is unrelated to the LiveStream changes in this PR.
Action Taken: Triggered rerun of failed jobs in run 37088727273.

(This report was generated by overseer)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenfield Indicates implementation of a new resource (vs migration) overseer step/mockgcp

2 participants