Skip to content

fix(functions): WIP update and fix functions_billing_stop sample #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions functions/billing/stop_billing/.gcloudignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# This file specifies files that are *not* uploaded to Google Cloud Platform
# using gcloud. It follows the same syntax as .gitignore, with the addition of
# "#!include" directives (which insert the entries of the given .gitignore-style
# file at that point).
#
# For more information, run:
# $ gcloud topic gcloudignore
#
.gcloudignore
# If you would like to upload your .git directory, .gitignore file or files
# from your .gitignore file, remove the corresponding line
# below:
.git
.gitignore

node_modules
117 changes: 117 additions & 0 deletions functions/billing/stop_billing/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// [START functions_billing_stop]
const {CloudBillingClient} = require('@google-cloud/billing');
const functions = require('@google-cloud/functions-framework');
const gcpMetadata = require('gcp-metadata');

const billing = new CloudBillingClient();

functions.cloudEvent('stopBilling', async cloudEvent => {
// TODO(developer): As stopping billing is a destructive action
// for your project, change the following constant to false
// after you validate with a test budget.
const simulateDeactivation = true;

let projectId;

try {
projectId = await gcpMetadata.project('project-id');
} catch (error) {
console.error('project-id metadata not found:', error);
return;
}

const projectName = `projects/${projectId}`;

const eventData = Buffer.from(
cloudEvent.data['message']['data'],
'base64'
).toString();

const eventObject = JSON.parse(eventData);

console.log(
`Cost: ${eventObject.costAmount} Budget: ${eventObject.budgetAmount}`
);

if (eventObject.costAmount <= eventObject.budgetAmount) {
console.log('No action required. Current cost is within budget.');
return;
}

console.log(`Disabling billing for project '${projectName}'...`);

const billingEnabled = await _isBillingEnabled(projectName);
if (billingEnabled) {
_disableBillingForProject(projectName, simulateDeactivation);
} else {
console.log('Billing is already disabled.');
}
});

/**
* Determine whether billing is enabled for a project
* @param {string} projectName The name of the project to check
* @returns {boolean} Whether the project has billing enabled or not
*/
const _isBillingEnabled = async projectName => {
try {
console.log(`Getting billing info for project '${projectName}'...`);
const [res] = await billing.getProjectBillingInfo({name: projectName});

return res.billingEnabled;
} catch (e) {
console.log('Error getting billing info:', e);
console.log(
'Unable to determine if billing is enabled on specified project, ' +
'assuming billing is enabled'
);

return true;
}
};

/**
* Disable billing for a project by removing its billing account
* @param {string} projectName The name of the project to disable billing
* @param {boolean} simulateDeactivation
* If true, it won't actually disable billing.
* Useful to validate with test budgets.
* @returns {void}
*/
const _disableBillingForProject = async (projectName, simulateDeactivation) => {
if (simulateDeactivation) {
console.log('Billing disabled. (Simulated)');
return;
}

// Find more information about `projects/updateBillingInfo` API method here:
// https://cloud.google.com/billing/docs/reference/rest/v1/projects/updateBillingInfo
try {
// To disable billing set the `billingAccountName` field to empty
const requestBody = {billingAccountName: ''};

const [response] = await billing.updateProjectBillingInfo({
name: projectName,
resource: requestBody,
});

console.log(`Billing disabled: ${JSON.stringify(response)}`);
} catch (e) {
console.log('Failed to disable billing, check permissions.', e);
}
};
// [END functions_billing_stop]
30 changes: 30 additions & 0 deletions functions/billing/stop_billing/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"name": "cloud-functions-stop-billing",
"private": "true",
"version": "0.0.1",
"description": "Disable billing with a budget notification.",
"main": "index.js",
"engines": {
"node": ">=20.0.0"
},
"scripts": {
"compute-test": "c8 mocha -p -j 2 test/periodic.test.js --timeout=600000",
"test": "c8 mocha -p -j 2 test/index.test.js --timeout=5000 --exit"
},
"author": "Ace Nassri <anassri@google.com>",
"license": "Apache-2.0",
"dependencies": {
"@google-cloud/billing": "^4.0.0",
"@google-cloud/functions-framework": "^3.0.0",
"gcp-metadata": "^6.0.0"
},
"devDependencies": {
"c8": "^10.0.0",
"gaxios": "^6.0.0",
"mocha": "^10.0.0",
"promise-retry": "^2.0.0",
"proxyquire": "^2.1.0",
"sinon": "^18.0.0",
"wait-port": "^1.0.4"
}
}
152 changes: 152 additions & 0 deletions functions/billing/stop_billing/test/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
// Copyright 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

const {exec} = require('child_process');
const {request} = require('gaxios');
const assert = require('assert');
const sinon = require('sinon');
const waitPort = require('wait-port');
const {InstancesClient} = require('@google-cloud/compute');
const sample = require('../index.js');

const {BILLING_ACCOUNT} = process.env;

describe('functions/billing tests', () => {
let projectId;
before(async () => {
const client = new InstancesClient();
projectId = await client.getProjectId();
});
after(async () => {
// Re-enable billing using the sample file itself
// Invoking the file directly is more concise vs. re-implementing billing setup here
const jsonData = {
billingAccountName: `billingAccounts/${BILLING_ACCOUNT}`,
projectName: `projects/${projectId}`,
};
const encodedData = Buffer.from(JSON.stringify(jsonData)).toString(
'base64'
);
const pubsubMessage = {data: encodedData, attributes: {}};
await require('../').startBilling(pubsubMessage);
});

describe('notifies Slack', () => {
let ffProc;
const PORT = 8080;
const BASE_URL = `http://localhost:${PORT}`;

before(async () => {
console.log('Starting functions-framework process...');
ffProc = exec(
`npx functions-framework --target=notifySlack --signature-type=event --port ${PORT}`
);
await waitPort({host: 'localhost', port: PORT});
console.log('functions-framework process started and listening!');
});

after(() => {
console.log('Ending functions-framework process...');
ffProc.kill();
console.log('functions-framework process stopped.');
});

describe('functions_billing_slack', () => {
it('should notify Slack when budget is exceeded', async () => {
const jsonData = {costAmount: 500, budgetAmount: 400};
const encodedData = Buffer.from(JSON.stringify(jsonData)).toString(
'base64'
);
const pubsubMessage = {data: encodedData, attributes: {}};

const response = await request({
url: `${BASE_URL}/notifySlack`,
method: 'POST',
data: {data: pubsubMessage},
});

assert.strictEqual(response.status, 200);
assert.strictEqual(
response.data,
'Slack notification sent successfully'
);
});
});
});

describe('disables billing', () => {
let ffProc;
const PORT = 8081;
const BASE_URL = `http://localhost:${PORT}`;

before(async () => {
console.log('Starting functions-framework process...');
ffProc = exec(
`npx functions-framework --target=stopBilling --signature-type=event --port ${PORT}`
);
await waitPort({host: 'localhost', port: PORT});
console.log('functions-framework process started and listening!');
});

after(() => {
console.log('Ending functions-framework process...');
ffProc.kill();
console.log('functions-framework process stopped.');
});

describe('functions_billing_stop', () => {
xit('should disable billing when budget is exceeded', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This test case is currently marked as skipped (xit). It should be enabled and validated to ensure the function works as expected. Consider adding assertions to verify that billing is actually disabled after the function is executed.

Suggested change
xit('should disable billing when budget is exceeded', async () => {
it('should disable billing when budget is exceeded', async () => {
// Use functions framework to ensure sample follows GCF specification
// (Invoking it directly works too, but DOES NOT ensure GCF compatibility)
const jsonData = {costAmount: 500, budgetAmount: 400};
const encodedData = Buffer.from(JSON.stringify(jsonData)).toString(
'base64'
);
const pubsubMessage = {data: encodedData, attributes: {}};

const response = await request({
url: `${BASE_URL}/stopBilling`,
method: 'POST',
data: {data: pubsubMessage},
});

assert.strictEqual(response.status, 200);
assert.ok(response.data.includes('Billing disabled'));
});
});
});

describe('shuts down GCE instances', () => {
describe('functions_billing_limit', () => {
it('should attempt to shut down GCE instances when budget is exceeded', async () => {
const jsonData = {costAmount: 500, budgetAmount: 400};
const encodedData = Buffer.from(JSON.stringify(jsonData)).toString(
'base64'
);
const pubsubMessage = {data: encodedData, attributes: {}};
// Mock GCE (because real GCE instances take too long to start/stop)
const instances = [{name: 'test-instance-1', status: 'RUNNING'}];
const listStub = sinon
.stub(sample.getInstancesClient(), 'list')
.resolves([instances]);
const stopStub = sinon
.stub(sample.getInstancesClient(), 'stop')
.resolves({});
await sample.limitUse(pubsubMessage);
assert.strictEqual(listStub.calledOnce, true);
assert.ok(stopStub.calledOnce);
});
});
});
});
Loading
Loading