Skip to content

Conversation

@ric-bianchi
Copy link
Contributor

@ric-bianchi ric-bianchi commented Feb 25, 2025

Purpose

The default data/page_sharer.yaml file mentions the icon 'reddit-alien' in the Reddit section (which is commented out by default). However, the above mentioned icon is not found in the 'brands' collection (or in any other collections, as far as I could see).

This PR adds (back) the 'reddit-alien' icon to the brands icon collection, and updates the page_sharer.yaml file to use it.

Screenshots

The newly added Reddit reddit-alien icon in use, on the right:

image
ric-bianchi and others added 2 commits February 25, 2025 18:57
The default 'page_sharer.yaml' file mentions the icon 'reddit-alien' in the Reddit section (which is commented out by default). However, the above mentioned icon is not found in the 'brands' collection (or in any other collections, as far as I could see). This commit adds (back) the 'reddit-alien' icon.
@netlify
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for academic-demo canceled.

Name Link
🔨 Latest commit 83c601c
🔍 Latest deploy log https://app.netlify.com/sites/academic-demo/deploys/67c36739bd61550007b88d97
@ric-bianchi ric-bianchi changed the title Patch 1 Feb 25, 2025
@ric-bianchi
Copy link
Contributor Author

Hi, I just noticed that the newly added reddit-alien icon lacked the fill color, so it did not change its color to white when switching to the dark theme, as shown here below:

Screenshot 2025-02-27 at 15 23 35

Therefore, with my latest commit I added the fill="currentColor" setting to the SVG definition of the icon, so that its line is now correctly set to 'white' when in dark mode, as in the example here below:

Screenshot 2025-02-27 at 15 24 17
@gcushen gcushen changed the title Add (back) the missing reddit-alien Reddit icon Mar 1, 2025
@gcushen
Copy link
Collaborator

gcushen commented Mar 1, 2025

Renamed the icon to simply 'reddit' as in the Tailwind module we use our own SVG icon pack rather than Font Awesome which the Bootstrap module uses, and which contains that longer icon name.

Also, fixed a bug as the PR added an erroneous extra "

@gcushen gcushen enabled auto-merge (squash) March 1, 2025 20:06
@gcushen gcushen merged commit 44e7554 into HugoBlox:main Mar 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants