Fix progress bar display in resume-languages block #3252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for academic-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@gcushen It looks like my recent PRs are awaiting your approval:
Please let me know if I overlooked anything that might have triggered this requirement. |
…shoffset calculation to show accurate progress. Previously, progress bars displayed the gap segment (remaining progress) starting from the first quadrant, whereas for 80% progress it should appear in the 4th quadrant, causing the visual representation to appear inverted.
srgg
force-pushed
the
fix/resume-languages-stroke-dashoffset-calculation
branch
from
2eb6a44 to
6957d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix progress bar display in resume-languages block by correcting stroke-dashoffset calculation to show accurate progress. Previously, progress bars displayed the gap segment (remaining progress) starting from the first quadrant, whereas for 80% progress, it should appear in the 4th quadrant, causing the visual representation to appear inverted.
Screenshots
Before:
Progress bars displayed the gap segment (remaining progress) starting from the first quadrant, whereas for 80% progress it should
appear in the 4th quadrant
After:
Progress bars now correctly display 80% proficiency as 80% filled
Documentation
It is a bugfix; no documentation change is needed.