Skip to content

fix: regression with custom icon rendering #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcushen merged 1 commit into from
Oct 21, 2025
Merged

fix: regression with custom icon rendering #3279

gcushen merged 1 commit into from
Oct 21, 2025

Conversation

@olipinski
Copy link
Contributor

@olipinski olipinski commented Oct 19, 2025

Purpose

Fixes #3278. Icons are not rendered properly due to the variable $icon shadowing the outer scope variable of the same name.
@olipinski olipinski requested a review from gcushen as a code owner October 19, 2025 20:27
@netlify
Copy link

netlify bot commented Oct 19, 2025 •
edited
Loading

✅ Deploy Preview for academic-demo canceled.

Name Link
🔨 Latest commit 1c4569a
🔍 Latest deploy log https://app.netlify.com/projects/academic-demo/deploys/68f549c7058868000809fb48
@gcushen gcushen changed the title Fix shadowing outer scope Oct 21, 2025
@gcushen gcushen merged commit cdee5c8 into HugoBlox:main Oct 21, 2025
12 checks passed
@gcushen gcushen changed the title Fix regression with custom icon rendering Oct 21, 2025
@gcushen gcushen added the bug label Oct 21, 2025
@gcushen
Copy link
Collaborator

gcushen commented Oct 21, 2025

@olipinski thanks for contributing a fix :)
@olipinski olipinski deleted the icon-fix branch October 21, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug modules

2 participants

@olipinski @gcushen