allow MDQ "entity_transform": "percent_encoded" #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cf https://datatracker.ietf.org/doc/draft-young-md-query/ Allows to behave alike Shibboleth SP. Needed for french https://mdq.federation.renater.fr/ which currently does not handle SHA1 encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The feature or problem addressed by this PR
MDQ always uses sha1 entityId encoding, but some MDQ server only handle percent-encoding
IdentityPython/SATOSA#460
Then change allows to behave alike Shibboleth SP using
mdq.entity_transformto "percent_encoded"What your changes do and why you chose this solution
NB : the change introduces a mix of types for param
entity_transform: it was expecting a function or None. The change adds the possibility to handle string "percent_encoded". I don't enough about the code to know if that's ok...