fix:quick-sort-code-mistakes #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
首先原来的295行是少了个参数的。那按照我的理解，这里应该是将随机位置元素交换到最右边。 然后重新把改过的代码运行发现sort([4,3,5,5,4,5])是会得到[3,4,5,5,4,5]的，那按照我的理解，应该需要加上308行这样，去交换小于基准值和等于基准值两者的位置。因为left是是小于等于基准值的，而less是小于基准值。
与上次修改的原因一样
getLeft 和 getRight 如果该节点分别没有左节点和有节点，应该返回他本身吧。predecessor和successor的while的condition应该是在找到位置符合的时候停止，所以应该取反。
new MessageChannel返回的是两个message ports，所以不能这样使用。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
首先原来的295行是少了个参数的。那按照我的理解，这里应该是将随机位置元素交换到最右边。
然后重新把改过的代码运行发现sort([4,3,5,5,4,5])是会得到[3,4,5,5,4,5]的，那按照我的理解，应该需要加上308行这样，去交换小于基准值和等于基准值两者的位置。