Skip to content

Add resource_key_type feature - #1345

Open
brcebn wants to merge 4 commits into
JSONAPI-Resources:masterfrom
brcebn:fix--prod-issue
Open

Add resource_key_type feature#1345
brcebn wants to merge 4 commits into
JSONAPI-Resources:masterfrom
brcebn:fix--prod-issue

Conversation

@brcebn

@brcebn brcebn commented Dec 14, 2020

Copy link
Copy Markdown

Closes #1344

Related to #1343

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions
Signed-off-by: Brice <brice.bene@gmail.com>
Signed-off-by: Brice <brice.bene@gmail.com>
Signed-off-by: Brice <brice.bene@gmail.com>
@brcebn

brcebn commented Dec 15, 2020

Copy link
Copy Markdown
Author

It seems to have broken eager loading process but I'm not sure how/where and a lot of other this. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant