Skip to content

Fix show_related_resources and top_level_meta_include_page_count - #1392

Open
bliof wants to merge 1 commit into
JSONAPI-Resources:masterfrom
bliof:fix-relationships-without-paginations
Open

Fix show_related_resources and top_level_meta_include_page_count#1392
bliof wants to merge 1 commit into
JSONAPI-Resources:masterfrom
bliof:fix-relationships-without-paginations

Conversation

@bliof

@bliof bliof commented Jun 21, 2022

Copy link
Copy Markdown

problem:

When the paginator is :none and top_level_meta_include_page_count is true
The show_related_resources was crashing as the paginator is nil

solution:

Just fixing the immediate problem but the code still leaves page_count
as nil in the meta

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions
@bliof
Fix show_related_resources to work with global config
4840292 
problem:

When the paginator is :none and top_level_meta_include_page_count is true
The show_related_resources was crashing as the paginator is nil

solution:

Just fixing the immediate problem but the code still leaves page_count
as nil in the meta
@bliof
bliof force-pushed the fix-relationships-without-paginations branch from 35ed838 to 4840292 Compare June 21, 2022 20:12
@bliof bliof changed the title Fix show_related_resources to work with global config Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@bliof