Skip to content

Restore use_related_resource_records_for_joins for v0_10 - #1412

Merged
lgebhardt merged 5 commits into
v0-11-devfrom
restore_use_related_records_v10
Sep 26, 2023
Merged

Restore use_related_resource_records_for_joins for v0_10#1412
lgebhardt merged 5 commits into
v0-11-devfrom
restore_use_related_records_v10

Conversation

@lgebhardt

@lgebhardt lgebhardt commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions
@lgebhardt
lgebhardt marked this pull request as ready for review September 26, 2023 13:43
@lgebhardt
lgebhardt merged commit 8932a6d into v0-11-dev Sep 26, 2023
@lgebhardt
lgebhardt deleted the restore_use_related_records_v10 branch September 26, 2023 13:43
lgebhardt added a commit that referenced this pull request Apr 18, 2024
@lgebhardt
Restore use_related_resource_records_for_joins for v0_10 (#1412)
125cef4 
* Restore `use_related_resource_records_for_joins` for v0_10

* Handle nil actual hashes

* Add back join_options for v10 compatibility

* Test JoinManager not JoinManagerV10

* Use sql_for_compare to account for different sql dialect quoating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@lgebhardt