Skip to content

Namespace references to Rails using ::Rails to avoid conflicts with… - #1421

Merged
lgebhardt merged 2 commits into
v0-11-devfrom
v0-11-dev-rails-namespace
Nov 16, 2023
Merged

Namespace references to Rails using ::Rails to avoid conflicts with…#1421
lgebhardt merged 2 commits into
v0-11-devfrom
v0-11-dev-rails-namespace

Conversation

@lgebhardt

@lgebhardt lgebhardt commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

Fixes #1413

Replaces #1414 for the v0-11-dev branch, which will eventually be merged to master

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions
@lgebhardt
lgebhardt requested a review from bf4 November 1, 2023 16:38
@lgebhardt
lgebhardt merged commit 1bdacf1 into v0-11-dev Nov 16, 2023
@lgebhardt
lgebhardt deleted the v0-11-dev-rails-namespace branch November 16, 2023 14:30
@lgebhardt lgebhardt mentioned this pull request Nov 16, 2023
Closed
12 tasks
lgebhardt added a commit that referenced this pull request Apr 18, 2024
@lgebhardt
Namespace references to Rails using ::Rails to avoid conflicts with… (
c36af71 
#1421)

* Namespace references to Rails using `::Rails` to avoid conflicts with other gems

* Use uppercase JSONAPI module name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@lgebhardt