Skip to content

fix: validate type matches resource type for sparse fieldsets - #1461

Merged
bf4 merged 1 commit into
JSONAPI-Resources:v0-11-devfrom
adamkiczula:bug/invalid_type_sparse_fieldsets
Nov 21, 2024
Merged

fix: validate type matches resource type for sparse fieldsets#1461
bf4 merged 1 commit into
JSONAPI-Resources:v0-11-devfrom
adamkiczula:bug/invalid_type_sparse_fieldsets

Conversation

@adamkiczula

Copy link
Copy Markdown

Fixes #1460

Ensures that the type provided to sparse fieldsets matches the type of the resulting resource.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions
@bf4
bf4 merged commit d3c094b into JSONAPI-Resources:v0-11-dev Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants