Fix identityHashCode in Wasm - #2913
Merged
Oleksandr Karpovich (eymar) merged 1 commit intoMar 25, 2026
Merged
Conversation
…even though it should return null. Js target correctly returns null and so '?:' correctly triggers
Author
Member
|
Thanks! |
Oleksandr Karpovich (eymar)
self-requested a review
March 25, 2026 15:18
Oleksandr Karpovich (eymar)
approved these changes
Mar 25, 2026
Oleksandr Karpovich (eymar)
merged commit Mar 25, 2026
8feb278
into
JetBrains:jb-main
24 of 26 checks passed
Zahari Zahariev (harryzz)
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
Fixes issue where WeakMap.get() was returning 0 instead of null when the value for the specified key was not found. In Js target this works correctly but not for Wasm for some reason. This is applying these [changes that where made in the Wasm source set in upstream Compose Runtime](https://android-review.googlesource.com/c/platform/frameworks/support/+/3987016) It should fix some recompositions for stable types since the indentity is now working correctly if cached. Maybe there are more obscure bugs that are affected by this that should be fixed ## Release Notes ### Fixes - Web - Fixes identity hash code not being correctly cached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where WeakMap.get() was returning 0 instead of null when the value for the specified key was not found. In Js target this works correctly but not for Wasm for some reason. This is applying these changes that where made in the Wasm source set in upstream Compose Runtime
It should fix some recompositions for stable types since the indentity is now working correctly if cached. Maybe there are more obscure bugs that are affected by this that should be fixed
Release Notes
Fixes - Web