Skip to content

Add support for GL_NV_explicit_typecast. #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alelenv wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for GL_NV_explicit_typecast. #4161

alelenv wants to merge 2 commits into from
+5,356 −4,922

Conversation

@alelenv
Copy link
Contributor

@alelenv alelenv commented Jan 23, 2026

GLSL spec here : KhronosGroup/GLSL#304

Glslang only change, no changes required for SPIRV Headers / Tools
@arcady-lunarg
Copy link
Contributor

arcady-lunarg commented Jan 23, 2026

Since the spec specifically calls out (vec3) (1, 2, 3) as something that's likely to give undesirable results, would it be possible to warn in that case? That seems like it would be a good way to let users know that their code is probably not doing what they want.
@arcady-lunarg arcady-lunarg self-requested a review January 23, 2026 21:37
@alelenv
Copy link
Contributor Author

alelenv commented Jan 27, 2026

@arcady-lunarg : Added a warning on accidental usage of sequence as operand to unary typecast
arcady-lunarg
arcady-lunarg approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Jan 29, 2026
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@alelenv @arcady-lunarg @kokoro-team