Skip to content

Conversation

@eltoder
Copy link
Contributor

@eltoder eltoder commented Mar 4, 2023

Another attempt at closing #83, since #89 seems stalled.

This also includes updating unit tests and the pure python implementation for consistency.

@elprans elprans requested a review from msullivan July 21, 2023 22:49
@eltoder eltoder force-pushed the feature/pep585-support branch 2 times, most recently from 6b30e74 to 69a14a2 Compare July 22, 2023 15:54
@eltoder
Copy link
Contributor Author

eltoder commented Jul 22, 2023

@elprans Thanks for looking! I made small changes to follow the style of stdlib.

Copy link
Contributor

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@elprans elprans merged commit 9ce64c5 into MagicStack:master Aug 14, 2023
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
@elprans elprans mentioned this pull request Aug 14, 2023
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants