Evaluate TextBox.LineCount only once in UpdateAttachedProperties #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
approved these changes
Jun 18, 2025
Member
Keboo
left a comment
Keboo
left a comment
There was a problem hiding this comment.
Awesome work on the analysis. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a performance issue in
TextBox.OnTextChangedhandler in Version 5.2.1 with poor responsiveness. I tracked it down to TextBoxLineCountBehavior:There has already been an improvement to queue the update with
Background-priority. That is good.But I also noticed, that
TextBox.LineCountis evaluated twice. This PR reduces the calls to one, so it improves background performance even more.