-
Notifications
You must be signed in to change notification settings - Fork 30
Don't match microblogs by magazine name hashtag anymore #1800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- previously we matched microblog post by their used hashtags and searched for magazines that define that hashtag or had a matching name. Change that to only use the defined hashtags from a magazine
befa25f to
f9e0b33
Compare
|
Uhm I don't now.. This means all microblogs will be empty by default under all the magazines..? Is my assume true? |
If that is true, then I'm a bit against it. |
I think that's a great idea! |
If I am correctly understanding the question, then no that that is not correct. As far as I know putting microblogs in magazines by their hashtag is not used widely (at least not intentionally). The way it is done usually in microblogs is by mentioning the magazine (which we also support). Making it opt out would mean that it will stay active in most cases as people are just not aware of it (I think). I am not entirely against it, I just think that it may miss the point... If all of youbare for it I have no problem doing it |
That's a good point, I'm not sure how many people are actually aware of it. |
Then why not try to make them more aware? Like mentioning it it the docs or even better: add a checkbox in the create magazine form to en- or disable the adding of the magazine-name-hashtag at creation. |
OK clear. I updated the title and description a bit to make this more clear. In that case I'm not fully against the change. But like other said, we could make it opt out per magazine or even maybe per instance. |
|
Yeah I think I'll add a migration that adds the magazine name as a tag in all local magazines. Then it is opt out and we control it. |
|
This PR is stale because it has been open 40 days with no activity. |

Uh oh!
There was an error while loading. Please reload this page.