Skip to content

Conversation

@BentiGorlich
Copy link
Member

@BentiGorlich BentiGorlich commented Nov 7, 2025

  • previously we matched microblog post by their used hashtags and searched for magazines that define that hashtag or had a matching name. Change that to only use the defined hashtags from a magazine
  • matching of magazine using the handle name will still work
@BentiGorlich BentiGorlich self-assigned this Nov 7, 2025
@BentiGorlich BentiGorlich added activitypub ActivityPub related issues backend Backend related issues and pull requests labels Nov 7, 2025
- previously we matched microblog post by their used hashtags and searched for magazines that define that hashtag or had a matching name. Change that to only use the defined hashtags from a magazine
@BentiGorlich BentiGorlich force-pushed the new/hashtag-match-not-by-magazine-name branch from befa25f to f9e0b33 Compare November 7, 2025 13:58
@melroy89
Copy link
Member

melroy89 commented Nov 7, 2025

Uhm I don't now.. This means all microblogs will be empty by default under all the magazines..?

Is my assume true?

@blued-gear
Copy link
Collaborator

Uhm I don't now.. This means all microblogs will be empty by default under all the magazines..?

If that is true, then I'm a bit against it.
The magazine-name tag could be added to newly created magazines automatically and show up it the settings (so that it is opt-out).

@jwr1
Copy link
Member

jwr1 commented Nov 7, 2025

The magazine-name tag could be added to newly created magazines automatically and show up it the settings (so that it is opt-out).

I think that's a great idea!

@BentiGorlich
Copy link
Member Author

This means all microblogs will be empty by default under all the magazines

If I am correctly understanding the question, then no that that is not correct. As far as I know putting microblogs in magazines by their hashtag is not used widely (at least not intentionally). The way it is done usually in microblogs is by mentioning the magazine (which we also support). Making it opt out would mean that it will stay active in most cases as people are just not aware of it (I think). I am not entirely against it, I just think that it may miss the point... If all of youbare for it I have no problem doing it

@jwr1
Copy link
Member

jwr1 commented Nov 8, 2025

Making it opt out would mean that it will stay active in most cases as people are just not aware of it (I think).

That's a good point, I'm not sure how many people are actually aware of it.

@blued-gear
Copy link
Collaborator

That's a good point, I'm not sure how many people are actually aware of it.

Then why not try to make them more aware? Like mentioning it it the docs or even better: add a checkbox in the create magazine form to en- or disable the adding of the magazine-name-hashtag at creation.

@melroy89 melroy89 changed the title Don't match microblogs by magazine name anymore Nov 10, 2025
@melroy89 melroy89 changed the title Don't match microblogs by magazine name hsshtag anymore Nov 10, 2025
@melroy89
Copy link
Member

This means all microblogs will be empty by default under all the magazines

If I am correctly understanding the question, then no that that is not correct. As far as I know putting microblogs in magazines by their hashtag is not used widely (at least not intentionally). The way it is done usually in microblogs is by mentioning the magazine (which we also support). Making it opt out would mean that it will stay active in most cases as people are just not aware of it (I think). I am not entirely against it, I just think that it may miss the point... If all of youbare for it I have no problem doing it

OK clear. I updated the title and description a bit to make this more clear.

In that case I'm not fully against the change. But like other said, we could make it opt out per magazine or even maybe per instance.

@melroy89
Copy link
Member

Since we "merged" the threads together with the microblog, here is an example where my updates magazine gets pollute by a random post:

image
@BentiGorlich
Copy link
Member Author

Yeah I think I'll add a migration that adds the magazine name as a tag in all local magazines. Then it is opt out and we control it.
And also add a checkbox on magazine creation like mention here 👍

@BentiGorlich BentiGorlich marked this pull request as draft November 11, 2025 12:27
@BentiGorlich BentiGorlich added this to the v1.9.1 milestone Nov 17, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open 40 days with no activity.

@github-actions github-actions bot added the Stale Inactivity for too long label Dec 28, 2025
@BentiGorlich BentiGorlich removed the Stale Inactivity for too long label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

activitypub ActivityPub related issues backend Backend related issues and pull requests

5 participants