Skip to content

Improve DI for testing #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BentiGorlich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve DI for testing #1973

BentiGorlich wants to merge 2 commits into from

Conversation

@BentiGorlich
Copy link
Member

@BentiGorlich BentiGorlich commented Jan 27, 2026

If we're in the test environment we should never load ApHttpClient or ImageManager because these classes actually request things from other servers, which we do not want while testing. Instead we want to automatically get our testing services. This PR autowires the testing services when we're in the test environment
@BentiGorlich
Improve DI for testing
5465d77 
If we're in the test environment we should never load `ApHttpClient` or `ImageManager` because these classes actually request things from other servers, which we do not want while testing.
Instead we want to automatically get our testing services. This PR autowires the testing services when we're in the test environment
@BentiGorlich BentiGorlich self-assigned this Jan 27, 2026
@BentiGorlich BentiGorlich added the DX Impacts developer experience label Jan 27, 2026
@BentiGorlich BentiGorlich marked this pull request as ready for review January 27, 2026 21:26
@BentiGorlich BentiGorlich mentioned this pull request Jan 27, 2026
Merged
@melroy89
Copy link
Member

melroy89 commented Jan 31, 2026

I agree. the test is however now failing:

In DefinitionErrorExceptionPass.php line 48:
                                                                               
  Cannot autowire service "App\Command\ApImportObject": argument "$client" of  
   method "__construct()" references interface "App\Service\ActivityPub\ApHtt  
  pClientInterface" but no such service exists. You should maybe alias this i  
  nterface to the existing "App\Tests\Service\TestingApHttpClient" service.
@BentiGorlich
Copy link
Member Author

BentiGorlich commented Jan 31, 2026

Yeah I know, but I don't know how to fix it. See symfony/symfony#63120
I linked it in the old PR, but forgot to mention it here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Impacts developer experience

3 participants

@BentiGorlich @melroy89