Skip to content

Fix the syntax of WITH clause #10105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

rrg92
Copy link
Contributor

@rrg92 rrg92 commented May 29, 2025

The previous syntax suggests that this works:

ALTER RESOURCE GOVERNOR RECONFIGURE WITH (CLASSIFIER_FUNCTION = NULL);

However, after running some tests I found that ALTER only supports the WITH clause when it is not preceded by RECONFIGURE. Therefore, that part should be moved so it is separate from the RECONFIGURE option.

Test on SQL 22 (also in sql 25 public preview):
image

This is the correct syntax:
image

Copy link
Contributor

@rrg92 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 7d4f961:

✅ Validation status: passed

File Status Preview URL Details
docs/t-sql/statements/alter-resource-governor-transact-sql.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@dimitri-furman dimitri-furman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the error in the syntax. We appreciate your contribution!

@v-regandowner
Copy link
Contributor

@dimitri-furman - I'll merge this PR based on your approval. If this article requires further changes, please open a separate pull request.

@v-regandowner v-regandowner merged commit 5508979 into MicrosoftDocs:live May 30, 2025
2 checks passed
Copy link
Contributor

PR 10105 has been merged from rrg92:patch-rg-with to MicrosoftDocs:live by v-regandowner.

@rrg92, @dimitri-furman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment