Conversation
b486477 to
8780ae6
Compare
|
momeemt
left a comment
There was a problem hiding this comment.
It failed to build by the following error even though linking package-lock.json in postPatch, I'll look into the cause.
❯ nix-build -A firebase-tools
this derivation will be built:
/nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv
building '/nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/6m5h6142z34fmwan06sg5vfq0s9nib3i-source
source root is source
Running phase: patchPhase
Executing npmConfigHook
Configuring npm
Validating consistency between /private/tmp/nix-build-firebase-tools-13.31.1.drv-0/source/package-lock.json and /nix/store/ynq87csgm3k1ay9gw6m9yjirp56h70f6-firebase-tools-13.31.1-npm-deps/package-lock.json
Fixing lockfile
\Installing dependencies
npm error code ENOTCACHED
npm error request to https://registry.npmjs.org/ajv-formats failed: cache mode is 'only-if-cached' but no cached response is available.
npm error Log files were not written due to an error writing to the directory: /nix/store/ynq87csgm3k1ay9gw6m9yjirp56h70f6-firebase-tools-13.31.1-npm-deps/_logs
npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
ERROR: npm failed to install dependencies
Here are a few things you can try, depending on the error:
1. Set `makeCacheWritable = true`
Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
2. Set `npmFlags = [ "--legacy-peer-deps" ]`
error: builder for '/nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv' failed with exit code 1;
last 10 log lines:
> npm error Log files were not written due to an error writing to the directory: /nix/store/ynq87csgm3k1ay9gw6m9yjirp56h70f6-firebase-tools-13.31.1-npm-deps/_logs
> npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
>
> ERROR: npm failed to install dependencies
>
> Here are a few things you can try, depending on the error:
> 1. Set `makeCacheWritable = true`
> Note that this won't help if npm is complaining about not being able to write to the logs directory -- look above that for the actual error.
> 2. Set `npmFlags = [ "--legacy-peer-deps" ]`
>
For full logs, run 'nix-store -l /nix/store/ks3yf0x7jgljpwd86rylxl62iy8sbcf5-firebase-tools-13.31.1.drv'.
sarahec
left a comment
There was a problem hiding this comment.
This is unnecessary, r-ryantm can handle updates without an explicit update script.
Thank you, I'll drop this change.
8780ae6 to
b8fcb0c
Compare
Well, nuts. It worked for me yesterday but not today. Thank you for looking into this. |
b8fcb0c to
317ed81
Compare
|
Hi @sarahec, I see I am requested for review. |
That request was by accident, this picked up an unrelated code-cursor change that I then fixed. |
|
firebase-tools maintainer here - chiming in to keep an eye on this and help out if needed. The shrinkwrap changes that @vkryachko mentioned were a result of adding overrides for ajv and ajv-format (https://github.com/firebase/firebase-tools/blob/master/package.json#L261). |
550efa5 to
d15f92c
Compare
|
@joehan could you review firebase/firebase-tools#8253 ? If it looks good, I can fettchpatch or bump this to the release containing it. |
Hi @sarahec , thanks for taking a look at this issue. I am wondering how have you arrived at this patch? Was it a manual change? if not, would be very interested to know how you did it and not recreating the lock file from scratch :) Also running --- a/npm-shrinkwrap.json
+++ b/npm-shrinkwrap.json
@@ -21059,6 +21059,8 @@
"integrity": "sha512-hTdwr+7yYNIT5n4AMYp85KA6yw2Va0FLa3Rguvbpa4W3I5x>
"dev": true,
"requires": {
+ "ajv": "^8.17.1",
+ "ajv-formats": "3.0.1",
"tslib": "^1.9.0"
}
},
@@ -24875,7 +24877,7 @@
"resolved": "https://registry.npmjs.org/ajv-formats/-/ajv-formats-3.0.1.>
"integrity": "sha512-8iUql50EUR+uUcdRQ3HDqa6EVyo3docL8g5WJ3FNcWmu62IbkGU>
"requires": {
- "ajv": "^8.0.0"
+ "ajv": "^8.17.1"
}
},
"ansi-align": { |
|
Thanks for the contribution @sarahec - I did some testing on it this morning and it looks good to me. I ran |
|
@vkryachko I applied this as a manual change. The shrinkwrap has many such changes due to the age of some of its components. @joehan just integrated your suggestion upstream, so we'll wait for that. @joehan thank you. I'll await the release later this week and bump this patch one last time. |
d15f92c to
54509d8
Compare
|
@joehan Thanks for all your help upstream. It's time to put this to bed. |
54509d8 to
68fbe42
Compare
|
Replaced by #386207 |

Replaced by #386207
13.30.0 -> 13.31.2
defaultandreqHandlerexports in Angular firebase/firebase-tools#8145)defaultandreqHandlerexports in Angular firebase/firebase-tools#8145)Updated the Firebase Data Connect local toolkit to v1.8.0, which includes several changes: (Bump FDC local toolkit to v1.8.0. firebase/firebase-tools#8210)
Enabled auto-updates via
passthru.updateScriptThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.