variety: install missing desktop file - #486304
Merged
Merged
Conversation
13 tasks
Contributor
|
The icon also needs to be installed. |
Contributor
Author
|
Good catch, thanks. I've added the scalable SVG icon installation in 006b8ea. The output now has both files: |
Contributor
Author
linsui
approved these changes
Feb 2, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The 0.9.0-b1 update (#477721) moved variety from
DistUtilsExtra.autoto plainsetuptools+setuptools-gettext. The old build system automatically processed and installedvariety.desktop.intoshare/applications/, but the newsetup.pyonly installsvariety.appdata.xmlviadata_files— the desktop file was dropped.This adds a
postInstallstep that usesintltool-merge(already innativeBuildInputs) to processvariety.desktop.inand install the resultingvariety.desktopto$out/share/applications/.Fixes the issue reported by @linsui in #477721 (comment).
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.