feat: add Hebrew translation and move hardcoded strings to i18n#74
Open
ClickAndGoScript wants to merge 2 commits into
Open
feat: add Hebrew translation and move hardcoded strings to i18n#74ClickAndGoScript wants to merge 2 commits into
ClickAndGoScript wants to merge 2 commits into
Conversation
- Add he (Hebrew) translation for all existing strings - Complete zh-CN translation (missing strings added) - Move hardcoded test notification text in library.js to [[web-push:test.*]] - Move hardcoded admin nav label in library.js to [[web-push:admin.menu-label]] - Replace hardcoded strings in ACP template with [[web-push:admin.*]] keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Hebrew (
he) translation and completes the missingzh-CNstrings.Also moves the remaining hardcoded strings — the test notification text, the
admin menu label, and the ACP page labels — into the language files, so they
render in the user's language instead of always appearing in English.
Closes #64 (partial — translations and i18n cleanup only).
@julianlam — in the end I let the agent handle it on its own, as you suggested.
Left to my own devices I probably would have been too lazy to open a separate branch for each feature.