Skip to content

3.3: schema tests for unevaluatedProperties #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ralfhandl wants to merge 1 commit into
base: v3.3-dev
Choose a base branch
from
Open

3.3: schema tests for unevaluatedProperties #5095

ralfhandl wants to merge 1 commit into from
+197 −0

Conversation

@ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Oct 31, 2025 •
edited
Loading

Many Objects defined in the spec don't allow additional properties.

Test these by taking a minimal instance that passes, inject a property with a very unlikely name and verify that it fails.

  • New "fail" test cases for Discriminator Object and External Documentation Object within a Schema Object, defined in meta.yaml
  • Table-driven test for Objects defined in schema.yaml with test cases in file minimal-objects.yaml

This brings subschema ("function") test coverage up to 100%.

  • no schema changes are needed for this pull request
@ralfhandl ralfhandl requested review from a team as code owners October 31, 2025 15:59
@ralfhandl ralfhandl mentioned this pull request Oct 31, 2025
Closed
1 task
@ralfhandl ralfhandl requested a review from a team November 3, 2025 07:45
miqui
miqui approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@miqui miqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok
@ralfhandl ralfhandl requested a review from a team January 25, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@ralfhandl @miqui @fred231084g