#198: Fixing false positive breaking change reported when removing an optional field from a response#327
Merged
Merged
Conversation
…nal field from a response. Closes OpenAPITools#198
orange-buffalo
commented
Jan 25, 2022
| @Test | ||
| public void testDiffDifferent() { | ||
| assertOpenApiBackwardIncompatible(OPENAPI_DOC1, OPENAPI_DOC2); | ||
| assertOpenApiBackwardCompatible(OPENAPI_DOC1, OPENAPI_DOC2, true); |
Contributor
Author
There was a problem hiding this comment.
This test actually covers the use case in #198, just has incorrect assertion.
orange-buffalo
commented
Jan 25, 2022
| schemas: | ||
| B: | ||
| type: object | ||
| required: ["message2"] |
Contributor
Author
There was a problem hiding this comment.
The test RecursiveSchemaTest expects backwards-incompatible change and by coincidence used removal of optional field from response as a change. Either the field should be required or the test should expect backwards-compatible change. I decided to go with the former.
julienrf
approved these changes
Feb 16, 2022
julienrf
left a comment
julienrf
left a comment
Contributor
There was a problem hiding this comment.
Thank you @orange-buffalo!
joschi
approved these changes
Feb 28, 2022
joschi
left a comment
joschi
left a comment
Contributor
There was a problem hiding this comment.
@orange-buffalo LGTM, thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198