Fix: BUG#348 Parameter change detection fix when path doesn't change but PathParams AND Parameters are changed (But named the same)#353
Merged
joschi merged 2 commits intoFeb 25, 2023
Conversation
mishukdutta-toast
force-pushed
the
diff-schema-detection-fix
branch
3 times, most recently
from
3513668 to
a2e94b8
Compare
* When endpoint pathParams change and Parameter names are changed to be similar to pathParams - Don't remove parameters from the path
mishukdutta-toast
force-pushed
the
diff-schema-detection-fix
branch
from
a2e94b8 to
917f857
Compare
mishukdutta-toast
changed the title
Contributor
Author
|
tagging @joschi for visibility |
joschi
approved these changes
Feb 25, 2023
joschi
left a comment
joschi
left a comment
Contributor
There was a problem hiding this comment.
@mishukdutta-toast Thanks for your contribution! ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangedParameter classto not lose parameters anddetect/returnchangesFixes: #353
removes Parameters which are marked - in: path
So changes to the schema for those parameters are not detected anymore when
.getParametersDiff().diff(...is run after removal