fix #358 - correction of regex problem + tests + auto formatting#359
Merged
Conversation
Contributor
Author
|
what do you think about it, @quen2404, @joschi and @misterjoshua ? |
|
|
joschi
approved these changes
Jun 7, 2022
joschi
left a comment
joschi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is an auto-formatting of some source files (when I executed
mvnw compile)you can also see the correction : I added "{}" in regex static variable
finally, you will see also 2 new YAML files used on a new test method to check is the problem is resolved