Skip to content

chore: update typescript samples#24159

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:update-samples
Jun 30, 2026
Merged

chore: update typescript samples#24159
wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:update-samples

Conversation

@Mattias-Sehlstedt

@Mattias-Sehlstedt Mattias-Sehlstedt commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Update typescript samples that were most likely missed in #23982.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Update TypeScript typescript-fetch kebab-case samples to cast value to Record<string, any> in instanceOfFormatTest and instanceOfEnumTest. This fixes strict TypeScript errors when checking _byte/byte and enumStringRequired fields and keeps the samples compiling.

Written for commit d25e2c2. Summary will update on new commits.

Review in cubic

@Mattias-Sehlstedt

Copy link
Copy Markdown
Contributor Author

@wing328 Update of outdated samples. discovered in #24158. See latest pipelines (1, 2) for additional examples.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@wing328 wing328 merged commit de10c92 into OpenAPITools:master Jun 30, 2026
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants