Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Fix print messages for MS-SSIM#230

Merged
Warvito merged 2 commits into
mainfrom
229-mssim-prints
Feb 7, 2023
Merged

Fix print messages for MS-SSIM#230
Warvito merged 2 commits into
mainfrom
229-mssim-prints

Conversation

@JessyD

@JessyD JessyD commented Feb 6, 2023

Copy link
Copy Markdown
Member

Fix #229

@JessyD JessyD requested a review from Warvito February 6, 2023 22:19

@Warvito Warvito left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is a detail regarding the use of f-strings that need to be corrected. Besides that, please run ./runtests.sh -f -u --net as added in the new Contributing,md (https://github.com/Project-MONAI/GenerativeModels/blob/main/CONTRIBUTING.md#unit-testing). It might ask to run ./runtests.sh --autofix to fix problems with formating

Comment thread generative/metrics/ms_ssim.py Outdated
@JessyD JessyD requested a review from Warvito February 7, 2023 15:54
@Warvito Warvito merged commit 69118fa into main Feb 7, 2023
@Warvito Warvito deleted the 229-mssim-prints branch February 7, 2023 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants