feat: support Kaplinghat halos in substructure arrays#567
Open
Jammy2211 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Workspace-test PR: PyAutoLabs/autolens_workspace_test#139 |
Collaborator
Author
|
Parking this PR outside the current release train per release triage; removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds PyAutoLens follow-up support for the Kaplinghat SIDM cored-NFW halo added in PyAutoGalaxy.
The substructure batching helper now explicitly packs supported halo profile parameter vectors instead of treating every non-cored-NFW profile as truncated NFW. It also supports the new Kaplinghat profile vector used by batched multi-plane substructure simulations.
API Changes
Adds support for
al.mp.KaplinghatCoredNFWSphandal.mp.KaplinghatCoredNFWMCRLudlowSphinautolens.lens.substructure_util.galaxies_to_halo_arrays.Unsupported profile classes now raise
ValueErrorinstead of being implicitly interpreted as truncated NFW profiles.See full details below.
Test Plan
NUMBA_CACHE_DIR=/tmp/numba_cache MPLCONFIGDIR=/tmp/matplotlib PYTHONPATH=/home/jammy/Code/PyAutoLabs/PyAutoConf:/home/jammy/Code/PyAutoLabs/PyAutoFit:/home/jammy/Code/PyAutoLabs/PyAutoArray:/home/jammy/Code/PyAutoLabs/PyAutoGalaxy:/home/jammy/Code/PyAutoLabs/PyAutoLens pytest -q test_autolens/lens/test_substructure_util.py test_autolens/test_config.py test_autolens/lensFull API Changes (for automation & release notes)
Removed
Added
autolens.lens.substructure_util.galaxies_to_halo_arrays(..., profile_cls=al.mp.KaplinghatCoredNFWSph)packs Kaplinghat halos as[centre_0, centre_1, kappa_s, scale_radius, interaction_radius, central_density, isothermal_radius].autolens.lens.substructure_util.galaxies_to_halo_arrays(..., profile_cls=al.mp.KaplinghatCoredNFWMCRLudlowSph)uses the same derived Kaplinghat parameter vector after the MCR constructor has computed the lensing-scale quantities.Changed Behaviour
autolens.lens.substructure_util.galaxies_to_halo_arraysnow raisesValueErrorfor unsupported halo profile classes instead of falling through to the truncated-NFW parameter extractor.Migration
cNFWSphandNFWTruncatedSphcallers keep the same parameter packing.galaxies_to_halo_arrays.Generated with Codex