Fix deprecation warnings #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `python-markdown`, this means bumping the minimum supported version to 3.0.0. For system dependencies, it means leaving python2 behind.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of deprecation warnings are currently raised by this library -- this PR fixes the ones I was experiencing.
Downsides:
python-markdownto3.0.0The part that I'm least confident in is the priority set during pattern registration. It's not entirely clear to me what it should be, but the proposed configuration sets it lower than all built-in priorities. I think the old version without explicit priority defaulted to a low value?
The tests pass for me, but I had a bit of trouble dealing with
toxand travis. I have a follow-up PR which swaps travis for Github Actions if you're interested, since travis is killing their free tier 😢